☂️-Issue for upgrading to k/*@v0.19 and controller-runtime@v0.7

[timebertt]

How to categorize this issue?

/area quality robustness open-source
/kind enhancement
/priority normal

What would you like to be added:

controller-runtime v0.7 was released. We can now go ahead our dependencies to k/*@v0.19 and c-r@v0.7.0.

This issue tracks all the tasks, that have to be done and should be followed up on, as the release is quite big.

Why is this needed:
We should adopt the newest improvements from upstream and shouldn't miss anything important during the migration 😄

	Status
✅	completed
☑️	partly completed
🚧	in progress
❔	to be clarified
ℹ️	interesting, but not relevant (yet)
❌	incomplete

To-Dos for g/g

• ✅ vendor k/*@v1.19, c-r@v0.7.0
• ✅ update our forks: third_party/forked/kubernetes (no action required) and github.com/gardener/kube-openapi
• ✅ remove client.Client implementation in pkg/client/kubernetes/utils in favor of manager.Options.ClientDisableCacheFor (ref ⚠Add ability for the delegating client to avoid caching objects kubernetes-sigs/controller-runtime#1249)
• ✅ adapt all helper functions to use client.Object where necessary, switch from controllerutils.Object to client.Object (ref ⚠ Introduce and use client.Object and client.ObjectList kubernetes-sigs/controller-runtime#1195)
• ✅ adapt all our reconcilers to the new reconciler interface (ref ⚠ Add a context w/ logger to Reconciler interface kubernetes-sigs/controller-runtime#1054)
• ✅ drop our c-r fork, which was vendored in order to include ⚠️ DynamicRestMapper: return NoMatchError when resource doesn't exist kubernetes-sigs/controller-runtime#1151
• ✅ adapt extensionshandler.EnqueueRequestsFromMapFunc and all extensions mappers to upstream interface changes (ref ✨ Simplify usage of EnqueueRequestsFromMapFunc kubernetes-sigs/controller-runtime#1119)
• ✅ remove usage from deperacted/removed helper funcs in pkg/log ⚠️ Remove deprecated pkg/runtime/log package and utils kubernetes-sigs/controller-runtime#1105
• ✅ migrate gardener-seed-admission-controller and shoot extension webhook handlers to controller-runtime handlers in order to adapt to changed admission types (make it work with both admission/{v1beta1,v1}) and get rid of custom handling/encoding/decoding logic (ref (ref ⚠️ pkg/webhook/admission: upgrade v1beta1 admission types to v1 kubernetes-sigs/controller-runtime#1284))
• ✅ adapt gardenlet bootstrap/cert rotation code to changes in csr client and API (ref CSR v1 - switch client-go certificate manager utility to v1 by default kubernetes/kubernetes#91754 and KEP#1513)

Follow-up tasks for g/g

• ✅ Remove kutils.KeyFromObject in favor of client.ObjectKeyFromObject (ref ⚠️ client.ObjectKeyFromObject now uses client.Client kubernetes-sigs/controller-runtime#1224) ➡️ Cleanup some deprecated helper funcs #3463
• ✅ Use vendored version flag: see here ➡️ Use version and verflag pkgs from k8s.io/component-base #3472
• ✅ Use autoscaling/v2beta2 for Kubernetes 1.12+ here ➡️ Use autoscaling/v2beta2 for seeds >= 1.12 #3486
• ✅ Remove kubernetes.Interface.RESTMapper in favor of client.RESTMapper (ref ⚠ Expose Client runtime.Scheme kubernetes-sigs/controller-runtime#1058, ⚠️ Expose RESTMapper on Client interface kubernetes-sigs/controller-runtime#1109, ...) ➡️ Remove kubernetes.Interface.RESTMapper in favor of client.RESTMapper #3473
• ✅ remove remaining meta.Accessor usages in favor of client.Object where applicable (ref ⚠ Introduce and use client.Object and client.ObjectList kubernetes-sigs/controller-runtime#1195) ➡️ Cleanup of runtime.Object and meta.Accessor #3476
• ✅ configure clients to use protobuf when talking to g-api (ref ⚠️ Use application/vnd.kubernetes.protobuf as content-type if possible kubernetes-sigs/controller-runtime#1149) ➡️ Use protobuf in gardener components #3467
• ✅ add some flags/options to make leader election lock of extension controllers / grm configurable (ref ✨ Make leader election resourcelock configurable kubernetes-sigs/controller-runtime#1147) ➡️ Add options for configuring leader election resource lock #3479
• ✅ remove finalizer-related helper funcs from pkg/controllerutils and extensions/pkg/controller in favor of controller-runtime/pkg/controller/controllerutil (ref ⚠️ Remove {Add,Remove}FinalizerWithError utils kubernetes-sigs/controller-runtime#1104) ➡️ Cleanup some deprecated helper funcs #3463
• ✅ migrate remaining webhook handlers in extensions and gardener-admission-controller to controller-runtime handlers as well to make it work with both admission/{v1beta1,v1}; adapt gardener webhook manifests and extension webhook self-registrations to also accept admission/v1 (ref ⚠️ pkg/webhook/admission: upgrade v1beta1 admission types to v1 kubernetes-sigs/controller-runtime#1284)
• ℹ️ a generic ComponentConfig implementation has been added (ref ⚠️ ComponentConfig Implementation kubernetes-sigs/controller-runtime#891)

Changes for extensions/repos vendoring g/g

	Meaning
⚠️	breaking change / action required
🏃	others, good to have
ℹ️	for information only, action depends

• ⚠️ check the release notes for further required actions
• ⚠️ vendor k/*@v1.19, c-r@v0.7.0
• ⚠️ drop gardener/controller-runtime fork, if vendored
• ⚠️ remove usage of client.Client implementation in pkg/client/kubernetes/utils in favor of manager.Options.ClientDisableCacheFor (ref ⚠Add ability for the delegating client to avoid caching objects kubernetes-sigs/controller-runtime#1249)
• ⚠️ WorkerDelegate.{MachineClass,MachineClassList} must now return client.{Object,ObjectList} instead of runtime.Object
• ⚠️ remove usage of controller.SetupSignalHandlerContext in favor of signals.SetupSignalHandler (ref ⚠️ Propagate context on Manager.Start(...) kubernetes-sigs/controller-runtime#1205)
• ⚠️ leader election is switched to ConfigMapsLeases by default, which requires new RBAC permissions for coordination.v1/lease (ref ⚠ Change leaderlock from ConfigMap to ConfigMapsLeasesResourceLock kubernetes-sigs/controller-runtime#1144)
• ⚠️ propagate contexts wherever it became necessary now (ref ⚠️ Propagate context.Context throughout the codebase kubernetes-sigs/controller-runtime#1116)
• ⚠️ adapt usage of handler.EnqueueRequestsFromMapFunc or extensionshandler.EnqueueRequestsFromMapper (ref ⚠️ Expose RESTMapper on Client interface kubernetes-sigs/controller-runtime#1109)
• ⚠️ adapt to other small self-explanatory breaking changes in gardener's packages
• 🏃 use new leaderelection flags/options
• 🏃 switch from zapr to klogr using the new flags/options/helpers
• ℹ️ default webhook port was changed to 9443 (ref ⚠️ Change default webhook port to 9443 kubernetes-sigs/controller-runtime#1076)
• ℹ️ "successful reconciliation" is no longer logged (ref ⚠️ Remove logs from internal controller kubernetes-sigs/controller-runtime#1096)

[timebertt]

we are planning to cut controller-runtime v0.7.0 on or just after 11/19 (two weeks from today)

🎉
ref https://groups.google.com/g/kubebuilder/c/9r0mqKl5ZFc/m/DUsEex_1AQAJ

[timebertt]

c-r@v0.7.0 was released

[timebertt]

For reference: my progress is on https://github.com/timebertt/gardener/commits/vendor/kk-cr

[MartinWeindel]

Note: On revendoring an extension you may run into a problem with the dependency github.com/googleapis/gnostic/openapiv2. The directory name changed from CamelCase to lowercase.
Depending on your git settings, you may have to delete the directory vendor/github.com/googleapis/gnostic/OpenAPIv2, commit the changes, and add it again after a make revendor

[timebertt]

/close
as all action items have been resolved.

Summarized some thoughts around consolidating the whole logging stuff in https://github.com/gardener/gardener-resource-manager/issues/66, but this is indeed a separate topic.