New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor gardener-seed-admission-controller #3459
Conversation
228e6ad
to
3827c70
Compare
3827c70
to
8925d62
Compare
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Very nice, thanks for adding the integration test!
pkg/operation/botanist/seedsystemcomponents/seedadmission/seedadmission.go
Show resolved
Hide resolved
8925d62
to
5c2c787
Compare
/lgtm I have a general question: I used to write |
5c2c787
to
41ee757
Compare
It's not the first one, but the second (#2830 was the first one) 😉
I plan to do the refactoring for gardener-admission-controller this week (similar to this PR). |
Rebased to resolve conflicts. |
* Refactor seed-admission-controller to use controller-runtime manager * Enable admission/v1 for GSAC * Decrease timeouts of extension deletion protection webhook * Add integration test for extension deletion protection * Migrate scheduler name webhook test to envtest * Improve test readability
* Refactor seed-admission-controller to use controller-runtime manager * Enable admission/v1 for GSAC * Decrease timeouts of extension deletion protection webhook * Add integration test for extension deletion protection * Migrate scheduler name webhook test to envtest * Improve test readability
How to categorize this PR?
/area quality dev-productivity
/kind cleanup test
/priority normal
What this PR does / why we need it:
This PR refactors/enhances several things regarding the
seed-admission-controller
:admission/v1
) in the webhook configs, as it is now supported by the c-r webhook handlers10s
according to best praticesenvtest
-style integration test for the extension deletion protection webhookenvtest
-style testWhich issue(s) this PR fixes:
Part of #3109
Special notes for your reviewer:
The PR got a bit bigger than expected, but it's still split into several commits, so I hope this helps with the review.
/squash
Release note: