Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protobuf in gardener components #2836

Closed
timebertt opened this issue Sep 10, 2020 · 2 comments · Fixed by #3467
Closed

Use protobuf in gardener components #2836

timebertt opened this issue Sep 10, 2020 · 2 comments · Fixed by #3467
Assignees
Labels
area/cost Cost related area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)

Comments

@timebertt
Copy link
Member

How to categorize this issue?

/area performance cost
/kind enhancement
/priority normal

What would you like to be added:
Currently all gardener components are configured to accept and send requests with content type application/json.
We should switch to protobuf (application/vnd.kubernetes.protobuf) by default, where possible.
As we heavily make use of CRDs in our Seed clusters it might not be possible to switch the seed client connection settings to protobuf at all, as CRDs don't support protobuf. But at least for the garden client connection it should be possible.
A fallback to json can be defined for acceptContentTypes with application/vnd.kubernetes.protobuf;application/json.

Why is this needed:
Using protobuf should be more efficient and might safe some data transfer costs.

@timebertt timebertt added the kind/enhancement Enhancement, improvement, extension label Sep 10, 2020
@gardener-robot gardener-robot added area/cost Cost related area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related priority/normal labels Sep 10, 2020
@gardener-robot gardener-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 10, 2020
@rfranzke rfranzke removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 20, 2020
@timebertt
Copy link
Member Author

timebertt commented Jan 12, 2021

This can be partly addressed with #3109 (ref kubernetes-sigs/controller-runtime#1149).
With that we will be able to configure c-r clients to use protobuf for the gardener APIs.

@timebertt
Copy link
Member Author

/assign

@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cost Cost related area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants