New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Kubernetes v1.20 #3296
Conversation
d85d0d4
to
c7ce8f9
Compare
c7ce8f9
to
28c0cb2
Compare
Apart from the failed verify step, it looks very good to me. I played with the PR locally extensively (seed bootstrap for v1.20; hibernation and wake up with v1.20; dynamic volume provisioning with CSI; worker pool with CRI; switch between IPVS and IPTables; worker with suse-chost) and it worked as expected. /lgtm |
f93d3f2
to
588143d
Compare
@ialidzhikov I've pushed a new commit 588143d which fixes the
That's awesome, thank you very much for your time and efforts and extensive testing, highly appreciated. 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Nice job! 👏
Thanks for your reviews, guys! I'm going ahead merging this now and marking the respective PRs on the provider extensions as ready for review. |
How to categorize this PR?
/area open-source usability
/kind enhancement
/priority normal
/merge keep-commits
/exp intermediate
/topology garden seed shoot
What this PR does / why we need it:
Support for Kubernetes v1.20
Which issue(s) this PR fixes:
Part of #3260
Special notes for your reviewer:
k8s.io/*
Golang sources yet - @timebertt plans to update tokubernetes-v1.19
as part of ☂️-Issue for upgrading to k/*@v0.19 and controller-runtime@v0.7 #3109.Release note: