Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Kubernetes v1.20 #3296

Merged
merged 6 commits into from Dec 17, 2020
Merged

Support for Kubernetes v1.20 #3296

merged 6 commits into from Dec 17, 2020

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area open-source usability
/kind enhancement
/priority normal
/merge keep-commits
/exp intermediate
/topology garden seed shoot

What this PR does / why we need it:
Support for Kubernetes v1.20

Which issue(s) this PR fixes:
Part of #3260

Special notes for your reviewer:

Release note:

Gardener can now support shoot clusters with Kubernetes version 1.20. In order to allow creation/update of 1.20 clusters you will have to update the version of your provider extension(s) to a version that supports 1.20 as well. Please consult the respective releases and notes in the provider extension's repository.

@rfranzke rfranzke requested a review from a team as a code owner December 14, 2020 12:44
@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related exp/intermediate kind/enhancement Enhancement, improvement, extension topology/garden Affects Garden clusters topology/seed Affects Seed clusters topology/shoot Affects Shoot clusters size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 14, 2020
@ialidzhikov
Copy link
Member

Apart from the failed verify step, it looks very good to me. I played with the PR locally extensively (seed bootstrap for v1.20; hibernation and wake up with v1.20; dynamic volume provisioning with CSI; worker pool with CRI; switch between IPVS and IPTables; worker with suse-chost) and it worked as expected.

/lgtm

Makefile Show resolved Hide resolved
@rfranzke
Copy link
Member Author

@ialidzhikov I've pushed a new commit 588143d which fixes the verify step, PTAL.

I played with the PR locally extensively (seed bootstrap for v1.20; hibernation and wake up with v1.20; dynamic volume provisioning with CSI; worker pool with CRI; switch between IPVS and IPTables; worker with suse-chost) and it worked as expected.

That's awesome, thank you very much for your time and efforts and extensive testing, highly appreciated. 👏

Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Nice job! 👏

@rfranzke
Copy link
Member Author

Thanks for your reviews, guys! I'm going ahead merging this now and marking the respective PRs on the provider extensions as ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related kind/enhancement Enhancement, improvement, extension size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. topology/garden Affects Garden clusters topology/seed Affects Seed clusters topology/shoot Affects Shoot clusters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants