Vendor k/*@v0.19 and controller-runtime@v0.7 #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/open-source
|
@timebertt Label kind/pain does not exist. |
gardener-robot
added
needs/review
size/XL
|
/assign |
|
/assign |
|
I had a quick chat with @mvladev about #3372 (comment). |
rfranzke
requested changes
Jan 13, 2021
There was a problem hiding this comment.
Well, first of all: Kudos and thanks a lot for this great PR. It's well structured and the dedicated commits helped tremendously to review it. It was a very smooth experience!
I've mainly found a few nits, not much. I've three "critical" questions when it comes to supporting old Kubernetes versions now that you upgraded certain APIs to new versions that are not available in older Kubernetes versions (which we still support, though).
cmd/gardener-seed-admission-controller/app/gardener_seed_admission_controller.go
Show resolved
Hide resolved
Yes, this seems like the better option for now. I added a deduplicating warnings handler to all components. |
rfranzke
approved these changes
Jan 14, 2021
|
Nice! Thanks a lot guys for your thorough and fast reviews! ❤️ |
|
😱 Probably :) |
ezeeyahoo
pushed a commit
to ezeeyahoo/gardener
that referenced
this pull request
Feb 17, 2021
* Vendor k/k@v1.19
* make generate after vendoring k/code-generator
* Adapt gardenlet boostrap and cert rotation code
* Vendor sigs.k8s.io/controller-runtime@v0.7.0
* Remove pkg/client/kubernetes/utils in favor of manager.Options.ClientDisableCacheFor
* Remove extensions/pkg/event in favor of simplified event.GenericEvent struct
* Replace runtime.Object with client.{Object,ObjectList}
* Adapt OperationAnnotationWrapper to client.Object
* Change ClientMap signatures to use contexts
* Adapt controllers to new reconciler.Reconcile interface
Adapt extension controllers to new reconciler.Reconcile interface
* Adapt event log helpers to new event type
* Adapt extensions mappers
* Adapt extensions webhooks to admissionv1
* Adapt seed admission webhooks
* Migrate seed-admission-controller to controller-runtime handlers
* Adapt and streamline signal handling
* Try to fix k-scheduler stuff under third_party
* Fix case sensitivity of gnostic dependency
* Fix bug in controller worker creation
* Address some first comments from rfranzke
* Address some first comments from timuthy
* Migrate shoot extension webhook handler to controller-runtime handler
* Make gardenlet bootstrap code fallback to certificates/v1beta1
* Address some first comments from ialidzhikov
* Pin sigs.k8s.io/structured-merge-diff/v3 back to fork
* Typo in test
* Deduplicate client-go warnings in all components
gardener-robot
added
priority/3
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Vendor k/k@v1.19
* make generate after vendoring k/code-generator
* Adapt gardenlet boostrap and cert rotation code
* Vendor sigs.k8s.io/controller-runtime@v0.7.0
* Remove pkg/client/kubernetes/utils in favor of manager.Options.ClientDisableCacheFor
* Remove extensions/pkg/event in favor of simplified event.GenericEvent struct
* Replace runtime.Object with client.{Object,ObjectList}
* Adapt OperationAnnotationWrapper to client.Object
* Change ClientMap signatures to use contexts
* Adapt controllers to new reconciler.Reconcile interface
Adapt extension controllers to new reconciler.Reconcile interface
* Adapt event log helpers to new event type
* Adapt extensions mappers
* Adapt extensions webhooks to admissionv1
* Adapt seed admission webhooks
* Migrate seed-admission-controller to controller-runtime handlers
* Adapt and streamline signal handling
* Try to fix k-scheduler stuff under third_party
* Fix case sensitivity of gnostic dependency
* Fix bug in controller worker creation
* Address some first comments from rfranzke
* Address some first comments from timuthy
* Migrate shoot extension webhook handler to controller-runtime handler
* Make gardenlet bootstrap code fallback to certificates/v1beta1
* Address some first comments from ialidzhikov
* Pin sigs.k8s.io/structured-merge-diff/v3 back to fork
* Typo in test
* Deduplicate client-go warnings in all components
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Vendor k/k@v1.19
* make generate after vendoring k/code-generator
* Adapt gardenlet boostrap and cert rotation code
* Vendor sigs.k8s.io/controller-runtime@v0.7.0
* Remove pkg/client/kubernetes/utils in favor of manager.Options.ClientDisableCacheFor
* Remove extensions/pkg/event in favor of simplified event.GenericEvent struct
* Replace runtime.Object with client.{Object,ObjectList}
* Adapt OperationAnnotationWrapper to client.Object
* Change ClientMap signatures to use contexts
* Adapt controllers to new reconciler.Reconcile interface
Adapt extension controllers to new reconciler.Reconcile interface
* Adapt event log helpers to new event type
* Adapt extensions mappers
* Adapt extensions webhooks to admissionv1
* Adapt seed admission webhooks
* Migrate seed-admission-controller to controller-runtime handlers
* Adapt and streamline signal handling
* Try to fix k-scheduler stuff under third_party
* Fix case sensitivity of gnostic dependency
* Fix bug in controller worker creation
* Address some first comments from rfranzke
* Address some first comments from timuthy
* Migrate shoot extension webhook handler to controller-runtime handler
* Make gardenlet bootstrap code fallback to certificates/v1beta1
* Address some first comments from ialidzhikov
* Pin sigs.k8s.io/structured-merge-diff/v3 back to fork
* Typo in test
* Deduplicate client-go warnings in all components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source quality
/kind task
/priority normal
What this PR does / why we need it:
This PR vendors all the kubernetes dependencies in version
v0.19.6and controller-runtime versionv0.7.0.See #3109 for more details.
Which issue(s) this PR fixes:
This is only the strictly required part of #3109
Special notes for your reviewer:
I tried to work in different commits to ease the review of this monstrous PR, each one of them addresses mainly one breaking change in upstream (though, it's not 100% accurately separated, just to ease the review).
/squash
gardener-seed-admission-controllercurrently uses some custom decoding and encoding logic for admission request and review, but uses the controller-runtime types for passing them down to the handlers.The upstream types were changed to
admission/v1(ref kubernetes-sigs/controller-runtime#1284).I didn't want to go through the hassle of adapting our logic to handle both admission versions, I rather removed the custom logic and migrated the handlers to use the upstream implementation.
I haven't migrated to the controller-runtime manager/webhook server yet and also haven't done the same change in the
gardener-admission-controller, as it wasn't strictly required and I wanted to keep this PR limited to the required changes in the upgrade process.Release note: