Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kubernetes.Interface.RESTMapper in favor of client.RESTMapper #3473

Merged
merged 1 commit into from Jan 29, 2021
Merged

Remove kubernetes.Interface.RESTMapper in favor of client.RESTMapper #3473

merged 1 commit into from Jan 29, 2021

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/kind cleanup
/priority normal

What this PR does / why we need it:

This PR cleans up the duplicated kubernetes.Interface.RESTMapper func in favor of client.RESTMapper.

Which issue(s) this PR fixes:
Part of #3109

Special notes for your reviewer:

Release note:

The `kubernetes.Interface.RESTMapper` func has been removed in favor of the `client.RESTMapper` func. Please adapt your usage accordingly.

@timebertt timebertt requested a review from a team as a code owner January 29, 2021 08:34
@gardener-robot gardener-robot added kind/cleanup Something that is not needed anymore and can be cleaned up priority/normal size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2021
@timebertt timebertt mentioned this pull request Jan 29, 2021
Closed
vpnachev
vpnachev approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

rfranzke
rfranzke approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 47fb7ee into gardener:master Jan 29, 2021
@timebertt timebertt deleted the cleanup/client-funcs branch January 29, 2021 11:15
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@timebertt
Remove kubernetes.Interface.RESTMapper in favor of client.RESTMapper (g…
ae3d6d0 
…ardener#3473)
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@timebertt
Remove kubernetes.Interface.RESTMapper in favor of client.RESTMapper (g…
19f855f 
…ardener#3473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
kind/cleanup Something that is not needed anymore and can be cleaned up size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@timebertt @vpnachev @rfranzke @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot