Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revendor gardener (k/*@v0.19) and controller-runtime v0.7.1 #258

Merged
merged 1 commit into from Jan 20, 2021
Merged

Revendor gardener (k/*@v0.19) and controller-runtime v0.7.1 #258

merged 1 commit into from Jan 20, 2021

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area open-source
/kind enhancement
/priority normal
/platform aws

What this PR does / why we need it:
Revendor gardener (k/*@v0.19) and controller-runtime v0.7.1

Which issue(s) this PR fixes:
Part of gardener/gardener#3109

Special notes for your reviewer:

Release note:

NONE

@rfranzke rfranzke requested a review from a team as a code owner January 19, 2021 08:44
@rfranzke
Copy link
Member Author

/test

@testmachinery
Copy link

testmachinery bot commented Jan 19, 2021 •
edited

Testrun: e2e-q6nzx
Workflow: e2e-q6nzx-wf
Phase: Failed

+---------------------+---------------------+--------+----------+
|        NAME         |        STEP         | PHASE  | DURATION |
+---------------------+---------------------+--------+----------+
| infrastructure-test | infrastructure-test | Failed | 21s      |
+---------------------+---------------------+--------+----------+

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 19, 2021
@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure priority/normal needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else kind/test Test labels Jan 19, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 19, 2021
@rfranzke
Copy link
Member Author

/test

@testmachinery
Copy link

testmachinery bot commented Jan 19, 2021 •
edited

Testrun: e2e-6q8cn
Workflow: e2e-6q8cn-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 12m2s    |
+---------------------+---------------------+-----------+----------+

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 19, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 19, 2021
@timuthy
Copy link
Contributor

timuthy commented Jan 19, 2021

/rebase

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Jan 19, 2021
@rfranzke
Copy link
Member Author

/remove needs/rebase

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 19, 2021
@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Jan 19, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 19, 2021
ialidzhikov
ialidzhikov approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 20, 2021
@gardener-robot gardener-robot removed the needs/second-opinion Needs second review by someone else label Jan 20, 2021
@rfranzke rfranzke merged commit dc75f2f into gardener:master Jan 20, 2021
@rfranzke rfranzke deleted the revendor/gg116 branch January 20, 2021 08:06
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@timebertt timebertt timebertt approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rfranzke @timuthy @ialidzhikov @timebertt @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot