New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup some deprecated helper funcs #3463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
kind/cleanup
Something that is not needed anymore and can be cleaned up
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Jan 27, 2021
timuthy
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold until v1.16 is released if you agree |
/unhold |
rfranzke
approved these changes
Jan 28, 2021
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Remove kutils.KeyFromObject in favor of client.ObjectKeyFromObject * Remove deprecated SimpleTaskFn * Remove controllerutils.HasFinalizer in favor of controllerutil.ContainsFinalizer * Remove controllerutils.BoolPtrDerefOr in favor of pointer.BoolPtrDerefOr * Remove extensionscontroller.HasFinalizer in favor of controllerutil.ContainsFinalizer
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Remove kutils.KeyFromObject in favor of client.ObjectKeyFromObject * Remove deprecated SimpleTaskFn * Remove controllerutils.HasFinalizer in favor of controllerutil.ContainsFinalizer * Remove controllerutils.BoolPtrDerefOr in favor of pointer.BoolPtrDerefOr * Remove extensionscontroller.HasFinalizer in favor of controllerutil.ContainsFinalizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/cleanup
Something that is not needed anymore and can be cleaned up
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind cleanup
/priority normal
What this PR does / why we need it:
Cleanup some deprecated / duplicated helper funcs.
Which issue(s) this PR fixes:
Part of #3109
Special notes for your reviewer:
/squash
Release note: