Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scheduler versions to third_party not a as module #3372

Merged
merged 1 commit into from Jan 11, 2021
Merged

Add scheduler versions to third_party not a as module #3372

merged 1 commit into from Jan 11, 2021

Conversation

mvladev
Copy link

@mvladev mvladev commented Jan 11, 2021

How to categorize this PR?

/area dev-productivity
/kind cleanup
/priority normal

What this PR does / why we need it:

Having modules makes vendoring gardener repository hard.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

Add scheduler versions to third_party not a as module
5124213 
Having modules makes vendoring gardener repository hard.
@mvladev mvladev requested a review from a team as a code owner January 11, 2021 09:03
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up priority/normal size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 11, 2021
vpnachev
vpnachev approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@mvladev mvladev merged commit 0c126cc into gardener:master Jan 11, 2021
@mvladev mvladev deleted the kube-scheduler-api-groups branch January 11, 2021 09:37
@timebertt
Copy link
Member

timebertt commented Jan 12, 2021 •
edited

@mvladev
I'm currently working on #3109 and was therefore also vendoring k/*.
TBH, this was a bit of pain with the scheduler stuff under third_party.
What am I supposed to do with those copied files when vendoring?
Can we please automate this when running make generate or revendor?

@timebertt timebertt mentioned this pull request Jan 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mvladev @timebertt @vpnachev @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot