Update Tests to use new 'verifyXxxxxx' method or 'execute' that use inlined config in Input files

[romani]

this is phase 2 of updates at #10390 (comment)
please see related commit to see how to update code and remove suppression line.

Test need to be updated:

• FileSetCheckTest

• AbstractFileSetCheckTest

• DetailAstImplTest

• TreeWalkerTest

• CheckerTest

• AllBlockCommentsTest

• AbstractCheckTest

• AllSinglelineCommentsTest

• SuppressionCommentFilterTest

• EmptyLineSeparatorCheckTest

• SuppressWarningsHolderTest

• ImportControlCheckTest

• ImportOrderCheckTest

• SuppressWithNearbyCommentFilterTest

• CommentsIndentationCheckTest

• SuppressionFilterTest

• WriteTagCheckTest

• AbstractJavadocCheckTest, covered by Issue #11446: Update AbstractJavadocCheckTest to use verifyWithInlineConfigParser #13951

• RegexpCheck not all methods migrated, covered by Issue #14064: Regexp: violation pointing to line 0 while other Checks count first line as 1 #14057 attention to method

suppression that was added at #11441 should be reemoved.

each Test should be updated in separate PR to ease review.

all usages of verify method should be changed to verifyWithInlineConfigParser or similar method that use Inlined to Input file configs. If not possible update to use execute method when test expect exception during execution and checking of violation is not required. Review #13951 on how to use test modules(inner lcasses) from config.

There are several test methods that create internal Check just to cover code by test and no verification of Java code, so execute method should be used instead verify.

ATTENTION: if migration is done for class, remove it from pom.xml in forbiddenapis-test config.

[nrmancuso]

I am on it, updating for AllSinglelineCommentsTest

[ghulamrabbani883]

Can I work on this issue

[romani]

Yes, select one, do comment "I am on ..." and send PR.
Please keep in mind, it is better to resolve first gsoc, second gsoc , before doing this "third".

[romani]

EmptyLineSeparatorCheckTest

Will be covered at #11408
@Kevin222004, fyi.

[Kevin222004]

@Rahulkhinchi03 Please give a look to this

EmptyLineSeparatorCheckTest

Will be covered at #11408 @Kevin222004, fyi.

It will be covering at #11408 it has been already mentioned by @romani , in conversation

[Rahulkhinchi03]

@Kevin222004 It was my mistake to open a PR on that. I am closing the PR. Thank you!

[Kevin222004]

@romani Please look at this

checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/MethodParamPadCheckTest.java

Lines 192 to 194 in 96e1142

	final String[] expected = CommonUtil.EMPTY_STRING_ARRAY;
	verify(createChecker(checkConfig), getPath("InputMethodParamPad4.java"), expected);

While working on the issue #11214 i have noticed this I guess this should also be updated

[Kevin222004]

@romani ping,

please let me know if I am wrong

[romani]

Yes it should be updated to use execute method

[Vyom-Yadav]

@romani @nick-mancuso Why does execute use the traditional way of building configurations and not the parser? If the reason behind it is that it traverses all the lines in the file to setViolations then a execute method could be made that just set the configuration using the input file and parser and does not set violations.

[nrmancuso]

Why does execute use the traditional way of building configurations and not the …

The “check” that I created it for was not a real check, we just needed to execute a fake check with no properties on code to count lines. We should not use this method for real checks, IMO.

#11447