Issue checkstyle#11446: Update TestTabViolation Method Of Checkertest

piyush-1234 · Feb 12, 2024 · b98957c · b98957c
1 parent 28e85b7
commit b98957c
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 11 deletions.
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/CheckerTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/CheckerTest.java
@@ -1408,13 +1408,11 @@ public void testHaltOnExceptionOff() throws Exception {
 
     @Test
     public void testTabViolationDefault() throws Exception {
-        final DefaultConfiguration checkConfig =
-            createModuleConfig(VerifyPositionAfterTabFileSet.class);
         final String[] expected = {
-            "2:9: violation",
-            "3:17: violation",
+            "10:17: violation",
+            "13:33: violation",
         };
-        verify(checkConfig, getPath("InputCheckerTabCharacter.txt"),
+        verifyWithInlineConfigParser(getPath("InputCheckerTabCharacter.txt"),
             expected);
     }
 
@@ -1425,8 +1423,8 @@ public void testTabViolation() throws Exception {
         final DefaultConfiguration checkerConfig = createRootConfig(checkConfig);
         checkerConfig.addProperty("tabWidth", "4");
         final String[] expected = {
-            "2:5: violation",
-            "3:9: violation",
+            "10:13: violation",
+            "13:33: violation",
         };
         verify(checkerConfig, getPath("InputCheckerTabCharacter.txt"),
             expected);

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/bdd/TestInputConfiguration.java b/src/test/java/com/puppycrawl/tools/checkstyle/bdd/TestInputConfiguration.java
@@ -56,7 +56,8 @@ public final class TestInputConfiguration {
             "com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck",
             "com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck",
             "com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheckTest$ViolationFileSetCheck",
-            "com.puppycrawl.tools.checkstyle.api.FileSetCheckTest$TestFileSetCheck"
+            "com.puppycrawl.tools.checkstyle.api.FileSetCheckTest$TestFileSetCheck",
+            "com.puppycrawl.tools.checkstyle.CheckerTest$VerifyPositionAfterTabFileSet"
     ));
 
     private final List<ModuleInputConfiguration> childrenModules;

diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checker/InputCheckerTabCharacter.txt b/src/test/resources/com/puppycrawl/tools/checkstyle/checker/InputCheckerTabCharacter.txt
@@ -1,3 +1,13 @@
-//has no tabs
-	//has tab
-		//has 2 tabs
+/*
+com.puppycrawl.tools.checkstyle.CheckerTest$VerifyPositionAfterTabFileSet
+
+*/
+
+// has no tabs
+line1
+
+// has a tab
+    line4	// violation
+
+// has 2 tabs
+        line5	// violation	// violation