Issue #11446: Update EmptyLineSeparatorCheckTest to use verifyWithInlineConfigParser #11472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romani
requested changes
Mar 26, 2022
| getPath("InputEmptyLineSeparatorJavadocCommentAfterPackage.java"), | ||
| expected); | ||
| execute(checkConfig, | ||
| getPath("InputEmptyLineSeparatorJavadocCommentAfterPackage.java")); |
There was a problem hiding this comment.
Changes done
There was a problem hiding this comment.
You need to convert to new method only places where we expect exception.
All other should be converted to method that use inlined config in Input files.
There was a problem hiding this comment.
I believe that we should not use execute here as I am getting PMD error and If I am using veriftWithInlineConfigParser and changing the config in input files then all tests are passing.
But after changing the input files, I am getting a code coverage issues.
There was a problem hiding this comment.
update test to not use "verify" and use verifyWithInlineConfigParser
…ineConfigParser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves update for EmptyLineSeparatorCheckTest in #11446.