Issue #11446: Update SuppressionCommentFilterTest to use verifyWithIn… #11503
Conversation
src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionCommentFilterTest.java
Show resolved
Hide resolved
| illegalClassNames = (default)Error, Exception, RuntimeException, Throwable, java.lang.Error, \ | ||
| java.lang.Exception, java.lang.RuntimeException, java.lang.Throwable | ||
|
|
||
|
|
There was a problem hiding this comment.
whole content of this file is not relevant, please remove header comment, and whole body of class.
there should be only empty class.
As we do not use violation of this class.
Apply the same to another Input file.
There was a problem hiding this comment.
I removed all the header/comments except Filter config as, without it, the exception is expected and the exception wasn't getting caught.
There was a problem hiding this comment.
please investigate a problem.
you use execute(treeWalkerConfig so it means that you get config created in test method (not a Input file).
execute method does not parse Input file.
There was a problem hiding this comment.
I tried to remove all the comments from the filter config and found that:
/*
SuppressionCommentFilter
offCommentFormat = (default)CHECKSTYLE:OFF
onCommentFormat = (default)CHECKSTYLE:ON
*/
With the above comments, the tests were passing but after removing offCommentFormat = (default)CHECKSTYLE:OFF and onCommentFormat = (default)CHECKSTYLE:ON the test gets fail and asked for the exception is expected.
There was a problem hiding this comment.
I updated code to make it work, you need debug code.
There was a problem hiding this comment.
Changes Done. I got it.
…lineConfigParser
Resolves update for SuppressionCommentFilterTest in #11446.