Issue #11446: Update CheckerTest method testUnmappableCharacters #14492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrccl
force-pushed
the
update-testUnmappableCharacthers-method-of-checkertest
branch
2 times, most recently
from
7314b14
to
01b7ebc
Compare
romani
requested changes
Feb 17, 2024
There was a problem hiding this comment.
please investigate test coverage reduction
https://github.com/checkstyle/checkstyle/actions/runs/7941288117/job/21683472819?pr=14492
it is blocker to merge
chrccl
force-pushed
the
update-testUnmappableCharacthers-method-of-checkertest
branch
3 times, most recently
from
6edb023
to
d021f7f
Compare
chrccl
force-pushed
the
update-testUnmappableCharacthers-method-of-checkertest
branch
from
d021f7f
to
0b66794
Compare
|
@romani ping |
romani
requested changes
Feb 21, 2024
| <mutatedClass>com.puppycrawl.tools.checkstyle.Checker</mutatedClass> | ||
| <mutatedMethod>setCharset</mutatedMethod> | ||
| <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> | ||
| <description>Removed assignment to member variable charset</description> |
There was a problem hiding this comment.
Sorry, this is not acceptable.
We can only remove mutation survival, extension is not allowed.
Please investigate why it happened.
romani
requested changes
Mar 16, 2024
| checkerConfig.addProperty("charset", "IBM1098"); | ||
|
|
||
| verify(checkerConfig, getPath("InputCheckerTestCharset.java"), expected); | ||
| verifyWithInlineConfigParser(getPath("InputCheckerTestCharset.java"), expected); |
There was a problem hiding this comment.
please reuase verifyWithInlineXmlConfig method, it fully supports xml configs
|
@chrccl , ping |
|
We have lost contact with author, anyone is welcome to reuse changes here to close the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11446: Update CheckerTest method testUnmappableCharacters