Issue checkstyle#11446: Update CheckerTest method testUnmappableChara…

…cters
LakshmiSowmya04 · Apr 5, 2024 · 85ff7cc · 85ff7cc
1 parent f7e952b
commit 85ff7cc
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 12 deletions.
diff --git a/config/suppressions.xml b/config/suppressions.xml
@@ -14,6 +14,8 @@
   <suppress checks="FileLength"
              files="TokenTypes.java|IndentationCheckTest.java|XdocsPagesTest|CheckerTest.java"
              lines="1"/>
+
+  <suppress checks="LineLength" files="CheckerTest.java"/>
 
   <!-- illegal words are part of Javadoc -->
   <suppress checks="TodoComment" files=".*TodoCommentCheck\.java"/>

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/CheckerTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/CheckerTest.java
@@ -84,9 +84,8 @@
 import com.puppycrawl.tools.checkstyle.internal.utils.CloseAndFlushTestByteArrayOutputStream;
 import com.puppycrawl.tools.checkstyle.internal.utils.TestUtil;
 import com.puppycrawl.tools.checkstyle.utils.CommonUtil;
-import de.thetaphi.forbiddenapis.SuppressForbidden;
 
-/**
+/**N
  * CheckerTest.
  *
  * @noinspection ClassWithTooManyDependencies
@@ -1656,20 +1655,13 @@ public void testCachedFile() throws Exception {
         checker.destroy();
     }
 
-    @SuppressForbidden
     @Test
     public void testUnmappableCharacters() throws Exception {
         final String[] expected = {
-            "4: " + getCheckMessage(LineLengthCheck.class, MSG_KEY, 75, 238),
+            "14: " + getCheckMessage(LineLengthCheck.class, MSG_KEY, 80, 100),
         };
-
-        final DefaultConfiguration checkConfig = createModuleConfig(LineLengthCheck.class);
-        checkConfig.addProperty("max", "75");
-
-        final DefaultConfiguration checkerConfig = createRootConfig(checkConfig);
-        checkerConfig.addProperty("charset", "IBM1098");
-
-        verify(checkerConfig, getPath("InputCheckerTestCharset.java"), expected);
+
+        verifyWithInlineXmlConfig(getPath("InputCheckerTestCharset.xml"), expected);
     }
 
     @Test

diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checker/InputCheckerTestCharset.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checker/InputCheckerTestCharset.java
@@ -1,3 +1,12 @@
+/*xml
+<module name="Checker">
+  <module name="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck">
+    <property name="max" value="80"/>
+  </module>
+  <property name="charset" value="IBM1098"/>
+</module>
+*/
+
 package com.puppycrawl.tools.checkstyle.checker;
 
 public class InputCheckerTestCharset {