-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove suppressions for original verify method or explain in comment #10390
Comments
Link is working fine, bunch of suppression still there, we need to cleanup/explain them or fix them. |
Yes, we claim now that all is resolved Line 1544 in 5e43145
But I would rather recheck why list is so big. There might be some new separate tickets need to be created to resolve some of them. See PR below, we might need check onemore time all excludes to prove reason that we cannot use new api (and write a reason in comment over exlude) or do final update. |
I am closing this issue, we will do final updates at #11446 |
Before:
#10391
#10081
Scope of this issue:
verify
method or expalin each/group of suppression why they stay permanent. All tests on fake/test Checks should be suppressed permanently, as there is no business value in such tests and they exists only for coverage of edge cases that are not achievable by existing public Checks.Suppression:
checkstyle/pom.xml
Line 1530 in 0544f86
we need clear explanation on why each suppresion is required. If we are on lack of time to migrate, but there is no good reason to stay in permanent, separate issue should be create and placed as comment
<!-- until LINK-->
The text was updated successfully, but these errors were encountered: