Issue checkstyle#11446: Update checker test method testUnmappableChar…

…acters
chrccl · Feb 16, 2024 · 8d481b1 · 8d481b1
1 parent c1ca1b9
commit 8d481b1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 12 deletions.
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/CheckerTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/CheckerTest.java
@@ -84,7 +84,6 @@
 import com.puppycrawl.tools.checkstyle.internal.utils.CloseAndFlushTestByteArrayOutputStream;
 import com.puppycrawl.tools.checkstyle.internal.utils.TestUtil;
 import com.puppycrawl.tools.checkstyle.utils.CommonUtil;
-import de.thetaphi.forbiddenapis.SuppressForbidden;
 
 /**
  * CheckerTest.
@@ -429,13 +428,21 @@ public void testSetters() {
         checker.setFileExtensions(".java", "xml");
 
         try {
-            checker.setCharset("UNKNOWN-CHARSET");
+            checker.setCharset("invalid_charset_name");
             assertWithMessage("Exception is expected").fail();
         }
         catch (UnsupportedEncodingException ex) {
             assertWithMessage("Error message is not expected")
                 .that(ex.getMessage())
-                .isEqualTo("unsupported charset: 'UNKNOWN-CHARSET'");
+                .isEqualTo("unsupported charset: 'invalid_charset_name'");
+        }
+
+        try {
+            final String validCharset = "UTF-8";
+            checker.setCharset(validCharset);
+        }
+        catch (UnsupportedEncodingException ex) {
+            assertWithMessage("Unexpected exception: " + ex.getClass().getName()).fail();
         }
     }
 
@@ -1659,20 +1666,13 @@ public void testCachedFile() throws Exception {
         checker.destroy();
     }
 
-    @SuppressForbidden
     @Test
     public void testUnmappableCharacters() throws Exception {
         final String[] expected = {
-            "4: " + getCheckMessage(LineLengthCheck.class, MSG_KEY, 75, 238),
+            "9: " + getCheckMessage(LineLengthCheck.class, MSG_KEY, 80, 100),
         };
 
-        final DefaultConfiguration checkConfig = createModuleConfig(LineLengthCheck.class);
-        checkConfig.addProperty("max", "75");
-
-        final DefaultConfiguration checkerConfig = createRootConfig(checkConfig);
-        checkerConfig.addProperty("charset", "IBM1098");
-
-        verify(checkerConfig, getPath("InputCheckerTestCharset.java"), expected);
+        verifyWithInlineConfigParser(getPath("InputCheckerTestCharset.java"), expected);
     }
 
     @Test

diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checker/InputCheckerTestCharset.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checker/InputCheckerTestCharset.java
@@ -1,3 +1,8 @@
+/*
+com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck
+
+*/
+
 package com.puppycrawl.tools.checkstyle.checker;
 
 public class InputCheckerTestCharset {