Issue #11446: Update CheckerTest method testUnmappableCharacters #14776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mahfouz72 can u please let me know if there is any mistake which I did |
mahfouz72
reviewed
Apr 10, 2024
| checkerConfig.addProperty("charset", "IBM1098"); | ||
|
|
||
| verify(checkerConfig, getPath("InputCheckerTestCharset.java"), expected); | ||
| verifyWithInlineXmlConfig(getPath("InputCheckerTestCharset.java"), expected); |
There was a problem hiding this comment.
you have to put the config comment in xml format in the beginning of this input file
There was a problem hiding this comment.
Why are we using verifyWithInlineXmlConfig instead of verifyWithInlineConfig?
There was a problem hiding this comment.
I will use verifyWithInlineConfig and will make PR again
....I used filename.xml before because of which I was mistaken
Thanks for the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #11446 by updating the CheckerTest method testUnmappableCharacters
Please look into this PR and let me know if there is something I need to change.