Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump junit-pioneer from 1.6.2 to 1.7.0 #1555

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 11, 2022

Bumps junit-pioneer from 1.6.2 to 1.7.0.

Release notes

Sourced from junit-pioneer's releases.

v1.7.0

Changelog generated by Shipkit Changelog Gradle Plugin

1.7.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner April 11, 2022 06:24
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 11, 2022
@JoergSiebahn
Copy link
Contributor

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/gradle/master/org.junit-pioneer-junit-pioneer-1.7.0 branch from df68230 to fa30388 Compare April 12, 2022 14:39
@JoergSiebahn
Copy link
Contributor

@dependabot rebase

Bumps [junit-pioneer](https://github.com/junit-pioneer/junit-pioneer) from 1.6.2 to 1.7.0.
- [Release notes](https://github.com/junit-pioneer/junit-pioneer/releases)
- [Commits](junit-pioneer/junit-pioneer@v1.6.2...v1.7.0)

---
updated-dependencies:
- dependency-name: org.junit-pioneer:junit-pioneer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/master/org.junit-pioneer-junit-pioneer-1.7.0 branch from fa30388 to 55d418a Compare April 12, 2022 15:10
@JoergSiebahn
Copy link
Contributor

This change makes this test fail.

@JoergSiebahn
Copy link
Contributor

I fixed the test case in this commit.

In my opinion that is not a perfect solution.

The need of this change also implies that we are causing a breaking change for our consumers with the update to junit-pioneer 1.7.0. This breaking change affects all consumers that have a similar test setup with a Dropwizard app and one of the affected extensions. I'm not sure how many services are affected and if that could be mitigated as simple as here.

@github-actions
Copy link
Contributor

Unit Test Results

   774 files  ±0     774 suites  ±0   16m 24s ⏱️ - 2m 38s
1 241 tests ±0  1 235 ✔️ ±0    6 💤 ±0  0 ±0 
3 744 runs  ±0  3 726 ✔️ ±0  18 💤 ±0  0 ±0 

Results for commit fb2d47d. ± Comparison against base commit 5b443e0.

@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JoergSiebahn JoergSiebahn marked this pull request as draft April 13, 2022 14:07
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 25, 2022

A newer version of org.junit-pioneer:junit-pioneer exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@JoergSiebahn
Copy link
Contributor

solution in progress, let's wait for a new version based on junit-pioneer/junit-pioneer#641

@JoergSiebahn
Copy link
Contributor

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 22, 2022

Superseded by #1957.

@dependabot dependabot bot closed this Nov 22, 2022
@dependabot dependabot bot deleted the dependabot/gradle/master/org.junit-pioneer-junit-pioneer-1.7.0 branch November 22, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant