Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JDK used for builds #606

Closed
nipafx opened this issue Mar 10, 2022 · 2 comments · Fixed by #608
Closed

Update JDK used for builds #606

nipafx opened this issue Mar 10, 2022 · 2 comments · Fixed by #608
Labels
⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) 📖 theme: build 🏗️ type: enhancement 🛸 3rd-party: Github Actions 🛸 3rd-party: Gradle

Comments

@nipafx
Copy link
Member

nipafx commented Mar 10, 2022

We currently build with JDK 8. This turned out to be a problem in #565 because that compiler version creates unsuppressible deprecation warnings, which that PR turns into errors - hence the build fails.

Building on JDK 11 should be straightforward. Right? 🧐
@nipafx nipafx changed the title Update build JDK Update JDK used for builds Mar 10, 2022
@Marcono1234
Copy link
Contributor

Possibly related to #567 (depending on how far you want to go for solving this issue here)

@Michael1993
Copy link
Member

Building on JDK 11, sure. It can be done in like 15 minutes. But I think we shouldn't stop there - let's update the whole codebase to Java 11!

@Michael1993 Michael1993 mentioned this issue Mar 14, 2022
Merged
14 tasks
Michael1993 added a commit that referenced this issue Mar 17, 2022
@Michael1993
Update to JDK 11 (#606 / #608)
90129df 
Updates the build to use JDK 11.

Closes: #606 
PR: #608
@beatngu13 beatngu13 mentioned this issue Apr 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) 📖 theme: build 🏗️ type: enhancement 🛸 3rd-party: Github Actions 🛸 3rd-party: Gradle
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update JDK for CI build to 11 junit-pioneer/junit-pioneer
3 participants
@Michael1993 @nipafx @Marcono1234