Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JUnit to 5.8 (#594 / #612) #612

Merged
merged 1 commit into from Mar 31, 2022

Conversation

Bukama
Copy link
Member

@Bukama Bukama commented Mar 27, 2022

The temporary directory/resource extension proposed in #348 / #491
requires parameter-level extension registration, which was added in
JUnit Jupiter 5.8.01.

Closes: #594
PR: #612


I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

Footnotes

  1. https://junit.org/junit5/docs/5.8.0/release-notes/index.html

The temporary directory/resource extension proposed in junit-pioneer#348 / junit-pioneer#491
requires parameter-level extension registration, which was added in
JUnit Jupiter 5.8.0[1].

[1]: https://junit.org/junit5/docs/5.8.0/release-notes/index.html

Closes: junit-pioneer#594
PR: junit-pioneer#612
@aepfli
Copy link
Member

aepfli commented Mar 27, 2022

What is our future plan, do we want to only support one version in the future? I am just asking out of curiosity and we could reduce complexity within out pipeline, when we remove one axis from the matrix (the junit version)

Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see my earlier comment

@Bukama Bukama merged commit ecb726c into junit-pioneer:main Mar 31, 2022
@Bukama Bukama deleted the bishue594junit58 branch March 31, 2022 15:48
@nipafx
Copy link
Member

nipafx commented Apr 3, 2022

What is our future plan, do we want to only support one version in the future?

We should build against our baseline and at least also against the newest released Jupiter version, so we know early when problems come down the line.

@beatngu13 beatngu13 mentioned this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update JUnit to 5.8
5 participants