Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLA-Bot #591

Closed
aepfli opened this issue Feb 10, 2022 · 3 comments · Fixed by #610
Closed

Add CLA-Bot #591

aepfli opened this issue Feb 10, 2022 · 3 comments · Fixed by #610

Comments

@aepfli
Copy link
Member

aepfli commented Feb 10, 2022

Currently our CLA is just a text within the Pull Request. So far I (in me aka @aepfli) can not remember that i really checked when merging if the user agreed upon it.

Therefore i suggest to use https://github.com/apps/cla-bot which can automate this with an additional check. (as suggested by @beatngu13 )

As this is a change/application which needs certain permissions, we should discuss it, and decide upon feasibility - also i am not sure if somebody else besides @nipafx can do it.
@beatngu13
Copy link
Member

Regarding yesterday's discussion during the maintainer meeting, whether we need a CLA at all, I found this interesting blog post. Here it says:

GitHub made that relationship explicit by incorporating an inbound = outbound clause into its Terms of Service, meaning if a pull request is submitted via GitHub, it is submitted under the project’s open source license.

From the linked GitHub terms of service:

Whenever you add Content to a repository containing notice of a license, you license that Content under the same terms, and you agree that you have the right to license that Content under those terms. If you have a separate agreement to license that Content under different terms, such as a contributor license agreement, that agreement will supersede.

So currently our CLA supersedes our license. But our license (section 2 "GRANT OF RIGHTS") already says:

Subject to the terms of this Agreement, each Contributor hereby grants Recipient a non-exclusive, worldwide, royalty-free copyright license to reproduce, prepare Derivative Works of, publicly display, publicly perform, Distribute and sublicense the Contribution of such Contributor, if any, and such Derivative Works.

Does that mean, at least in our case, the CLA is indeed unnecessary?

@nipafx
Copy link
Member

nipafx commented Feb 17, 2022 •
edited

That would be really great! That means, we'd not only avoid the CLA bot, we could even remove the CLA and instead explain what you described - mostly just copy/paste your comment. 😆

@beatngu13 beatngu13 mentioned this issue Mar 17, 2022
Merged
14 tasks
@Bukama
Copy link
Member

Bukama commented Mar 19, 2022

I'm not a lawyer, so I leave decision if we need/change this to others.

nipafx pushed a commit that referenced this issue Mar 27, 2022
@beatngu13
Remove CLA (#591 / #610)
9f133a6 
[GitHub's terms of service][gh-tos] already require users to agree
to our license and that they have the right to license their
contribution(s) under those terms. Therefore, having a dedicated CLA
is not necessary.

[gh-tos]: https://docs.github.com/en/site-policy/github-terms/github-terms-of-service#6-contributions-under-repository-license

Closes: #591
PR: #610
beatngu13 added a commit that referenced this issue Apr 5, 2022
@beatngu13
Remove CLA (#591 / #616)
19cdcb9 
[GitHub's terms of service][gh-tos] already require users to agree
to our license and that they have the right to license their
contribution(s) under those terms. Therefore, having a dedicated CLA
is not necessary.

[gh-tos]: https://docs.github.com/en/site-policy/github-terms/github-terms-of-service#6-contributions-under-repository-license

Closes: #591
PR: #616
@beatngu13 beatngu13 mentioned this issue Apr 11, 2022
Open
@aepfli aepfli mentioned this issue Jun 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove CLA junit-pioneer/junit-pioneer
4 participants
@Bukama @nipafx @aepfli @beatngu13