Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name attribute for @RetryingTest #601

Closed
crw614 opened this issue Mar 3, 2022 · 1 comment · Fixed by #603
Closed

Add name attribute for @RetryingTest #601

crw614 opened this issue Mar 3, 2022 · 1 comment · Fixed by #603
Labels
⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) 🚦 status: in progress 📖 theme: extensions 🏗️ type: enhancement

Comments

@crw614
Copy link

crw614 commented Mar 3, 2022 •
edited by Michael1993

Using @RetryingTest overwrites test names and causes a mess in test reports. @DisplayName does not work. Could you add an attribute to @RetryingTest that allows you to specify the format of the test name?
For example @RetryingTest(value = 3, name = "Custom name {currentTry}")

Example from junit5

current report look like it:
image
@Michael1993
Copy link
Member

Hi @crw614 👋

I wanted to let you know that @DisplayName works with the test container, but you have a valid point about a missing name attribute for test invocation. I'll try to get something done about this soon.

@Michael1993 Michael1993 changed the title Add name attribute for @RetryingTest Add name attribute for @RetryingTest Mar 3, 2022
@Michael1993 Michael1993 mentioned this issue Mar 3, 2022
Merged
9 tasks
nipafx pushed a commit that referenced this issue Mar 10, 2022
@Michael1993
Refactor test template name handling (#601 / #603)
ad7736a 
Due to Pioneer having multiple TestTemplate-based extensions,
the need for a unified `TestNameFormatter` arose. This moves
`CartesianTestNameFormatter` to the package `...internal`, so it
may be used by other extensions as well.

Closes: #601
PR: #603
nipafx pushed a commit that referenced this issue Apr 10, 2022
Add version for display-names in RetryingTest (#601)
c77441b
@beatngu13 beatngu13 mentioned this issue Apr 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) 🚦 status: in progress 📖 theme: extensions 🏗️ type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor test template name handling junit-pioneer/junit-pioneer
2 participants
@Michael1993 @crw614