Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CLA #616

Merged
merged 1 commit into from Apr 5, 2022
Merged

Remove CLA #616

merged 1 commit into from Apr 5, 2022

Conversation

beatngu13
Copy link
Member

@beatngu13 beatngu13 commented Apr 5, 2022

--force-with-lease! 馃槈

Proposed commit message:

Remove CLA (#591 / #616)

[GitHub's terms of service][gh-tos] already require users to agree
to our license and that they have the right to license their
contribution(s) under those terms. Therefore, having a dedicated CLA
is not necessary.

[gh-tos]: https://docs.github.com/en/site-policy/github-terms/github-terms-of-service#6-contributions-under-repository-license

Closes: #591
PR: #616

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Site documentation in .adoc file references demo in src/demo/java instead of containing code blocks as text
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.md mentions the new contribution (real name optional)

I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

@beatngu13 beatngu13 changed the title Remove CLA (#591 / TBA) Remove CLA Apr 5, 2022
@beatngu13 beatngu13 merged commit 19cdcb9 into main Apr 5, 2022
@beatngu13 beatngu13 deleted the issue/591-remove-cla branch April 5, 2022 18:48
@beatngu13 beatngu13 mentioned this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant