Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit default locale and timezone annotations #615

Merged
merged 6 commits into from Apr 7, 2022

Conversation

beatngu13
Copy link
Member

@beatngu13 beatngu13 commented Apr 3, 2022

Relates to #456.

Proposed commit message:

Inherit default locale and timezone annotations (#456 / TBA)

`@DefaultLocale` and `@DefaultTimeZone` are now `@Inherited`.

Relates to: #456
PR: #615 

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Site documentation in .adoc file references demo in src/demo/java instead of containing code blocks as text
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.md mentions the new contribution (real name optional)

@beatngu13 beatngu13 requested a review from Bukama April 3, 2022 13:18
Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear in docs too 👍

@Bukama Bukama added the full-build Triggers full build suite on PR label Apr 5, 2022
@Michael1993
Copy link
Member

Do we need to update site documentation?

@beatngu13
Copy link
Member Author

Probably a good idea, will update the site docs, too.

@Bukama
Copy link
Member

Bukama commented Apr 7, 2022

Thanks again. We can merge if you want.

@beatngu13 beatngu13 merged commit 9a90140 into main Apr 7, 2022
@beatngu13 beatngu13 deleted the issue/456-inherit-default-locale-timezone branch April 7, 2022 18:32
@beatngu13 beatngu13 mentioned this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-build Triggers full build suite on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants