Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JDK for CI build to 11 #608

Merged
merged 7 commits into from Mar 17, 2022
Merged

Update JDK for CI build to 11 #608

merged 7 commits into from Mar 17, 2022

Conversation

Michael1993
Copy link
Member

@Michael1993 Michael1993 commented Mar 13, 2022

Closes #606

Proposed commit message:

${action} (${issues} / ${pull-request}) [max 70 characters]

${body} [max 70 characters per line]

${references}: ${issues}
PR: ${pull-request}

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Site documentation in .adoc file references demo in src/demo/java instead of containing code blocks as text
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.md mentions the new contribution (real name optional)

I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

@Michael1993 Michael1993 added the full-build Triggers full build suite on PR label Mar 13, 2022
README.md Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
# SonarCloud analysis does not support Java 8, hence we need to execute the
# analysis separately with Java 11. This is fine because we are done with the basic
# builds for the contributors.
sonarcloud:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we really want to move the SonarCloud analysis into the basic build. Before:

grafik

Now:

grafik

IIRC so far a failing SonarCloud analysis wouldn't stop following jobs, because it represents a separate branch in the workflow. This is now no longer the case I believe.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't mind. I think we can commit to a stricter workflow.

Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Michael1993 Michael1993 merged commit 90129df into main Mar 17, 2022
@Michael1993 Michael1993 deleted the issue/606-jdk-build-to-11 branch March 17, 2022 17:55
Bukama pushed a commit that referenced this pull request Apr 10, 2022
#608 bumped to Java version used in our CI to a minimum of 11, except
for the `release` job.

PR: #620
@breun
Copy link

breun commented Apr 11, 2022

Does this mean JUnit Pioneer 1.7.0 won't be compatible with projects that use Java 8?

@Michael1993
Copy link
Member Author

Does this mean JUnit Pioneer 1.7.0 won't be compatible with projects that use Java 8?

Hi, sorry, no, this is a bit misleading - this is only for builds. The code base is still Java 8 and should be compatible with any project using Java 8.

@breun
Copy link

breun commented Apr 11, 2022

Ok great for the quick response, thanks!

@beatngu13
Copy link
Member

@breun FYI Pioneer 2.0 will likely use Java 11: #617

@beatngu13 beatngu13 mentioned this pull request Apr 11, 2022
@nipafx nipafx changed the title Update to JDK 11 Update JDK for CI build to 11 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-build Triggers full build suite on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update JDK used for builds
4 participants