Bump rubocop from 0.87.1 to 0.89.0 #300

dependabot · 2020-08-06T15:00:51Z

Bumps rubocop from 0.87.1 to 0.89.0.

Release notes

RuboCop 0.89

New features

#8322: Support autocorrect for Style/CaseEquality cop. ([@fatkodima][])

#7876: Enhance Gemspec/RequiredRubyVersion cop with check that required_ruby_version is specified. ([@fatkodima][])

#8291: Add new Lint/SelfAssignment cop. ([@fatkodima][])

#8389: Add new Lint/DuplicateRescueException cop. ([@fatkodima][])

#8433: Add new Lint/BinaryOperatorWithIdenticalOperands cop. ([@fatkodima][])

#8430: Add new Lint/UnreachableLoop cop. ([@fatkodima][])

#8412: Add new Style/OptionalBooleanParameter cop. ([@fatkodima][])

#8432: Add new Lint/FloatComparison cop. ([@fatkodima][])

#8376: Add new Lint/MissingSuper cop. ([@fatkodima][])

#8415: Add new Style/ExplicitBlockArgument cop. ([@fatkodima][])

#8383: Support autocorrect for Lint/Loop cop. ([@fatkodima][])

#8339: Add Config#for_badge as an efficient way to get a cop's config merged with its department's. ([@marcandre][])

#5067: Add new Style/StringConcatenation cop. ([@fatkodima][])

#7425: Add new Lint/TopLevelReturnWithArgument cop. ([@iamravitejag][])

#8417: Add new Style/GlobalStdStream cop. ([@fatkodima][])

#7949: Add new Style/SingleArgumentDig cop. ([@volfgox][])

#8341: Add new Lint/EmptyConditionalBody cop. ([@fatkodima][])

#7755: Add new Lint/OutOfRangeRegexpRef cop. ([@sonalinavlakhe][])

Bug fixes

#8346: Allow parentheses in single-line inheritance with Style/MethodCallWithArgsParentheses EnforcedStyle: omit_parentheses to fix invalid Ruby auto-correction. ([@gsamokovarov][])

#8324: Fix crash for Layout/SpaceAroundMethodCallOperator when using Proc#call shorthand syntax. ([@fatkodima][])

#8332: Fix auto-correct in Style/ConditionalAssignment to preserve constant namespace. ([@biinari][])

#8344: Fix crash for Style/CaseLikeIf when checking against equal? and match? without a receiver. ([@fatkodima][])

#8323: Fix a false positive for Style/HashAsLastArrayItem when hash is not a last array item. ([@fatkodima][])

#8299: Fix an incorrect auto-correct for Style/RedundantCondition when using raise, rescue, or and without argument parentheses in else. ([@koic][])

#8335: Fix incorrect character class detection for nested or POSIX bracket character classes in Style/RedundantRegexpEscape. ([@owst][])

#8347: Fix an incorrect auto-correct for EnforcedStyle: hash_rockets of Style/HashSyntax with Layout/HashAlignment. ([@koic][])

#8375: Fix an infinite loop error for Style/EmptyMethod. ([@koic][])

#8385: Remove auto-correction for Lint/EnsureReturn. ([@marcandre][])

#8391: Mark Style/ArrayCoercion as not safe. ([@marcandre][])

#8406: Improve Style/AccessorGrouping's auto-correction to remove redundant blank lines. ([@koic][])

#8330: Fix a false positive for Style/MissingRespondToMissing when defined method with inline access modifier. ([@koic][])

#8422: Fix an error for Lint/SelfAssignment when using or-assignment for constant. ([@koic][])

#8423: Fix an error for Style/SingleArgumentDig when without a receiver. ([@koic][])

#8424: Fix an error for Lint/IneffectiveAccessModifier when there is begin...end before a method definition. ([@koic][])

#8006: Fix line length calculation for Style/IfUnlessModifier to correctly take into account code before the if condition when considering conversation to a single-line form. ([@dsavochkin][])

#8283: Fix line length calculation for Style/IfUnlessModifier to correctly take into account a comment on the first line when considering conversation to a single-line form. ([@dsavochkin][])

#7957: Fix line length calculation for Style/IfUnlessModifier to correctly take into account code on the last line after the end keyword when considering conversion to a single-line form. ([@dsavochkin][])

#8226: Fix Style/IfUnlessModifier to add parentheses when converting if-end condition inside an array or a hash to a single-line form. ([@dsavochkin][])

#8443: Fix an incorrect auto-correct for Style/StructInheritance when there is a comment before class declaration. ([@koic][])

#8444: Fix an error for Layout/FirstMethodArgumentLineBreak when using kwargs in super. ([@koic][])

Changes

#8376: Style/MethodMissingSuper cop is removed in favor of new Lint/MissingSuper cop. ([@fatkodima][])

Changelog

Sourced from rubocop's changelog.

0.89.0 (2020-08-05)

New features

#8322: Support autocorrect for Style/CaseEquality cop. ([@fatkodima][])

#7876: Enhance Gemspec/RequiredRubyVersion cop with check that required_ruby_version is specified. ([@fatkodima][])

#8291: Add new Lint/SelfAssignment cop. ([@fatkodima][])

#8389: Add new Lint/DuplicateRescueException cop. ([@fatkodima][])

#8433: Add new Lint/BinaryOperatorWithIdenticalOperands cop. ([@fatkodima][])

#8430: Add new Lint/UnreachableLoop cop. ([@fatkodima][])

#8412: Add new Style/OptionalBooleanParameter cop. ([@fatkodima][])

#8432: Add new Lint/FloatComparison cop. ([@fatkodima][])

#8376: Add new Lint/MissingSuper cop. ([@fatkodima][])

#8415: Add new Style/ExplicitBlockArgument cop. ([@fatkodima][])

#8383: Support autocorrect for Lint/Loop cop. ([@fatkodima][])

#8339: Add Config#for_badge as an efficient way to get a cop's config merged with its department's. ([@marcandre][])

#5067: Add new Style/StringConcatenation cop. ([@fatkodima][])

#7425: Add new Lint/TopLevelReturnWithArgument cop. ([@iamravitejag][])

#8417: Add new Style/GlobalStdStream cop. ([@fatkodima][])

#7949: Add new Style/SingleArgumentDig cop. ([@volfgox][])

#8341: Add new Lint/EmptyConditionalBody cop. ([@fatkodima][])

#7755: Add new Lint/OutOfRangeRegexpRef cop. ([@sonalinavlakhe][])

Bug fixes

#8346: Allow parentheses in single-line inheritance with Style/MethodCallWithArgsParentheses EnforcedStyle: omit_parentheses to fix invalid Ruby auto-correction. ([@gsamokovarov][])

#8324: Fix crash for Layout/SpaceAroundMethodCallOperator when using Proc#call shorthand syntax. ([@fatkodima][])

#8332: Fix auto-correct in Style/ConditionalAssignment to preserve constant namespace. ([@biinari][])

#8344: Fix crash for Style/CaseLikeIf when checking against equal? and match? without a receiver. ([@fatkodima][])

#8323: Fix a false positive for Style/HashAsLastArrayItem when hash is not a last array item. ([@fatkodima][])

#8299: Fix an incorrect auto-correct for Style/RedundantCondition when using raise, rescue, or and without argument parentheses in else. ([@koic][])

#8335: Fix incorrect character class detection for nested or POSIX bracket character classes in Style/RedundantRegexpEscape. ([@owst][])

#8347: Fix an incorrect auto-correct for EnforcedStyle: hash_rockets of Style/HashSyntax with Layout/HashAlignment. ([@koic][])

#8375: Fix an infinite loop error for Style/EmptyMethod. ([@koic][])

#8385: Remove auto-correction for Lint/EnsureReturn. ([@marcandre][])

#8391: Mark Style/ArrayCoercion as not safe. ([@marcandre][])

#8406: Improve Style/AccessorGrouping's auto-correction to remove redundant blank lines. ([@koic][])

#8330: Fix a false positive for Style/MissingRespondToMissing when defined method with inline access modifier. ([@koic][])

#8422: Fix an error for Lint/SelfAssignment when using or-assignment for constant. ([@koic][])

#8423: Fix an error for Style/SingleArgumentDig when without a receiver. ([@koic][])

#8424: Fix an error for Lint/IneffectiveAccessModifier when there is begin...end before a method definition. ([@koic][])

#8006: Fix line length calculation for Style/IfUnlessModifier to correctly take into account code before the if condition when considering conversation to a single-line form. ([@dsavochkin][])

#8283: Fix line length calculation for Style/IfUnlessModifier to correctly take into account a comment on the first line when considering conversation to a single-line form. ([@dsavochkin][])

#7957: Fix line length calculation for Style/IfUnlessModifier to correctly take into account code on the last line after the end keyword when considering conversion to a single-line form. ([@dsavochkin][])

#8226: Fix Style/IfUnlessModifier to add parentheses when converting if-end condition inside an array or a hash to a single-line form. ([@dsavochkin][])

#8443: Fix an incorrect auto-correct for Style/StructInheritance when there is a comment before class declaration. ([@koic][])

#8444: Fix an error for Layout/FirstMethodArgumentLineBreak when using kwargs in super. ([@koic][])

#8448: Fix Style/NestedParenthesizedCalls to include line continuations in whitespace for auto-correct. ([@biinari][])

Changes

Commits

829c782 Cut 0.89
6042aed Small Style cops perf tweaks
a678aba [Fixes #7755] Add Lint/OutOfRangeRefInRegexp cop (#8407)
1fc1981 Fix move namespaced constant in Style/ConditionalAssignment (#8332)
f91df3e Add new Lint/EmptyConditionalBody cop
7048b51 Enhance Gemspec/RequiredRubyVersion cop with check that `required_ruby_vers...
426814e Support autocorrect for Lint/Loop cop
c29441f Optimize getting node tokens
d94c4a4 Add new Lint/BinaryOperatorWithIdenticalOperands cop
bf47e35 Don't mutate arguments.
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

coveralls · 2020-08-06T15:05:54Z

Coverage remained the same at 99.813% when pulling 9a7c72c on dependabot/bundler/rubocop-0.89.0 into 76541d7 on main.

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.87.1 to 0.89.0. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v0.87.1...v0.89.0) Signed-off-by: dependabot[bot] <support@github.com>

michaelabon · 2020-08-06T15:21:34Z

I can't upgrade to 0.89.0 because of the issue found and fixed in rubocop/rubocop#8467


Offenses:

bucket/bucket/processors/move_ass_hyphens.rb:5:46: W: Lint/UriRegexp: URI.regexp is obsolete and should not be used. Instead, use URI::DEFAULT_PARSER.make_regexp.
        return nil unless message.text.match(regexp)
                                             ^^^^^^
bucket/bucket/processors/move_ass_hyphens.rb:8:35: W: Lint/UriRegexp: URI.regexp is obsolete and should not be used. Instead, use URI::DEFAULT_PARSER.make_regexp.
          text: message.text.gsub(regexp, '\k<adj> ass-\k<noun>')
                                  ^^^^^^
bucket/bucket/processors/reverse_the_fucking.rb:6:47: W: Lint/UriRegexp: URI.regexp is obsolete and should not be used. Instead, use URI::DEFAULT_PARSER.make_regexp.
        return nil unless message.text.match?(regexp)
                                              ^^^^^^
bucket/bucket/processors/reverse_the_fucking.rb:9:34: W: Lint/UriRegexp: URI.regexp is obsolete and should not be used. Instead, use URI::DEFAULT_PARSER.make_regexp.
          text: message.text.sub(regexp, 'fucking the')
                                 ^^^^^^
bucket/bucket/processors/reverse_the_fucking.rb:16:27: W: Lint/UriRegexp: URI.regexp is obsolete and should not be used. Instead, use URI::DEFAULT_PARSER.make_regexp.
        message.text.scan(regexp).count == 1
                          ^^^^^^

dependabot · 2020-08-06T15:21:36Z

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot bot added the dependencies label Aug 6, 2020

dependabot bot assigned michaelabon Aug 6, 2020

dependabot bot mentioned this pull request Aug 6, 2020

Bump rubocop from 0.87.1 to 0.88.0 #295

Closed

dependabot bot force-pushed the dependabot/bundler/rubocop-0.89.0 branch from ce686b7 to 9a7c72c Compare August 6, 2020 15:18

michaelabon closed this Aug 6, 2020

michaelabon deleted the dependabot/bundler/rubocop-0.89.0 branch August 6, 2020 15:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump rubocop from 0.87.1 to 0.89.0 #300

Bump rubocop from 0.87.1 to 0.89.0 #300

dependabot bot commented on behalf of github Aug 6, 2020 •

edited

coveralls commented Aug 6, 2020 •

edited

michaelabon commented Aug 6, 2020

dependabot bot commented on behalf of github Aug 6, 2020

Bump rubocop from 0.87.1 to 0.89.0 #300

Bump rubocop from 0.87.1 to 0.89.0 #300

Conversation

dependabot bot commented on behalf of github Aug 6, 2020 • edited

RuboCop 0.89

New features

Bug fixes

Changes

0.89.0 (2020-08-05)

New features

Bug fixes

Changes

coveralls commented Aug 6, 2020 • edited

michaelabon commented Aug 6, 2020

dependabot bot commented on behalf of github Aug 6, 2020

dependabot bot commented on behalf of github Aug 6, 2020 •

edited

coveralls commented Aug 6, 2020 •

edited