Allow parentheses in single-line inheritance #8346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsamokovarov
force-pushed
the
allow-parens-in-single-line-inheritance
branch
4 times, most recently
from
5ea14fc
to
7f97cac
Compare
koic
reviewed
Jul 16, 2020
koic
reviewed
Jul 16, 2020
lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb
Outdated
Show resolved
Hide resolved
gsamokovarov
force-pushed
the
allow-parens-in-single-line-inheritance
branch
from
7f97cac
to
efe6c16
Compare
`class Point < Struct.new(:x, :y); end` was getting auto-corrected to `class Point < Struct.new :x, :y; end` which is invalid Ruby code. Allow the parentheses in this case for the following configurations: ```ruby Style/MethodCallWithArgsParentheses: EnforcedStyle: omit_parentheses ```
gsamokovarov
force-pushed
the
allow-parens-in-single-line-inheritance
branch
from
efe6c16
to
150e306
Compare
|
Thanks for the review, @koic, can you check the changes now? |
koic
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
class Point < Struct.new(:x, :y); endwas getting auto-corrected toclass Point < Struct.new :x, :y; endwhich is invalid Ruby code. Allowthe parentheses in this case for the following configurations: