Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Style/GlobalStdStream cop #8417

Merged
merged 1 commit into from Jul 30, 2020

Conversation

fatkodima
Copy link
Contributor

This cop enforces the use of $stdout/$stderr/$stdin instead of STDOUT/STDERR/STDIN.

https://rubystyle.guide/#global-stdout

# bad
STDOUT.puts('hello')

hash = { out: STDOUT, key: value }

def m(out = STDOUT)
  out.puts('hello')
end

# good
$stdout.puts('hello')

hash = { out: $stdout, key: value }

def m(out = $stdout)
  out.puts('hello')
end

@bbatsov bbatsov merged commit 260f5e3 into rubocop:master Jul 30, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Jul 30, 2020

Great work! 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants