Support autocorrect for Lint/Loop cop

[fatkodima]

No description provided.

[marcandre]

I think you might be loosing comments in this case:

begin
  something
end while # don't remove me
   test

May not be worth the worry.

[fatkodima]

I hope it is impossible to find the code like that 😄

This is much more possible:

begin
  something
end while test # don't remove me

And it will be correctly handled.

[bbatsov]

I wonder why we made this a lint cop, as I definitely don't remember it today. Seems we could have written better documentation. 😆

[marcandre]

Am I weird?

I prefer

loop do
  # ...
  break if condition
end

But I'd rather have

begin
   # ...
end while condition
# than
loop do
   # ...

  break unless condition
end

The answer is probably "yeah". I'm glad it's rare that there's a reason to loop

[bbatsov]

You're weird for sure, but then again - I've never had to use loop in my entire Ruby career. 😆

[fatkodima]

I've never had to use loop in my entire Ruby career. 😆

I have used loop, but I would say I have never used for loop (but I do not see it that bad as everybody talks), do not remember if I ever really used protected keyword with its intended purpose and never found the case where I really needed to made the choice between proc and lambda because of their differences.

[bbatsov]

The changes look good, but your branch has to be rebased on top of the current master branch due to merge conflicts.

[fatkodima]

Rebased.