Add new Lint/BinaryOperatorIdenticalOperands cop
#8433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Aug 4, 2020
| # end | ||
| # | ||
| class BinaryOperatorIdenticalOperands < Base | ||
| MSG = 'Binary operator has identical operands.' |
There was a problem hiding this comment.
I'd mention in the message the name of the binary operator (and maybe even the operand in question).
There was a problem hiding this comment.
Added mention about operator. I think, mentioning the operand is not necessary, as it will be obvious from code. Example: foo == foo.
bbatsov
reviewed
Aug 4, 2020
bbatsov
reviewed
Aug 4, 2020
fatkodima
force-pushed
the
binary_operator_identical_operands
branch
from
6b79b36
to
1d7a7e9
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by https://www.viva64.com/en/w/v501/
This cop supersedes (with other binary operators) and deprecates
Lint/UselessComparison. That existent cop should already be marked as unsafe due to reasons - https://github.com/rubocop-hq/rubocop/compare/master...fatkodima:binary_operator_identical_operands?expand=1#diff-e9973b98907964eb1cc98fd20b55fe1cR8-R10So I marked this cop as unsafe.