Add new Lint/EmptyConditionalBody cop
#8341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrosenblum
reviewed
Jul 15, 2020
lib/rubocop/cop/lint/uri_regexp.rb
Outdated
| else | ||
| captured_values = uri_regexp_without_argument?(node) | ||
| end | ||
| captured_values = |
There was a problem hiding this comment.
I'm always happy when a new cop catches weird code within our own source code. Really helps to confirm that the cop is useful.
|
The changes look good, but your branch has to be rebased on top of the current |
fatkodima
force-pushed
the
empty-conditional-body-cop
branch
from
7a3c4be
to
85bcc65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cop checks for empty bodies in
if/elsif/unlessbranches.This is in addition to existent
Lint/EmptyWhencop.