Fix line continuations in spec examples #8448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix backslash before newline.
Include backslash followed by newline as whitespace when replacing with
parentheses in Style/NestedParenthesizedCalls cop.
Fix existing spec for:
```ruby
puts(nex \
5)
```
to auto-correct to:
```ruby
puts(nex(5))
```
Originally the spec was written such that the backslash newline gets
interpreted when parsing the heredoc as:
```ruby
"puts(nex 5)\n"
```
biinari
force-pushed
the
fix/spec_line_continuations
branch
from
6b1e23e
to
b67bf30
Compare
8 tasks
marcandre
reviewed
Aug 5, 2020
| @@ -101,17 +105,27 @@ def directions(side) | |||
| end | |||
| end | |||
|
|
|||
| def final_pos(src, pos, increment, newlines, whitespace) | |||
| # rubocop:disable Metrics/ParameterLists | |||
| def final_pos(src, pos, increment, continuations, newlines, whitespace) | |||
There was a problem hiding this comment.
I imagine this method is not meant to be used directly? I really need to finish #8278 ...
There was a problem hiding this comment.
Indeed, there's a comment above that says these helpers are not supposed to be used directly. I agree it would be better to mark them individually as @api private.
|
Nice catch! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When describing the code that should be detected / auto-corrected, some specs do not escape line continuations properly.
For example:
results in the string
"something continues\n"instead of the desired"something \\\n continues\n"Correct specs escape the backslash or use single quoted heredocs to keep the line continuation in the source under test, like:
In correcting the specs, it became apparent that
Style/NestedParenthesizedCallscop did not behave as intended.RangeHelpmixin has been adapted to optionally include line continuations (backslash newline sequence).Feedback is welcome on whether this behaviour on replacing whitespace with parentheses matches with your expectations.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.