New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0 #6625
build(deps): Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0 #6625
Conversation
Bumps [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) from 1.5.0 to 1.7.0. - [Release notes](https://github.com/go-sql-driver/mysql/releases) - [Changelog](https://github.com/go-sql-driver/mysql/blob/master/CHANGELOG.md) - [Commits](go-sql-driver/mysql@v1.5.0...v1.7.0) --- updated-dependencies: - dependency-name: github.com/go-sql-driver/mysql dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
@pgporada heads up, we rolled 1.6.x back after experiencing connection churn in production. |
I was there, 84 years ago! |
Related #5437 |
I think we're going to have the same issue with this upgrade as we did with 1.6.0. My eyes don't see any particular commits that change/improve either of the PRs found in #5437 |
One thing that's changed: we've stopped propagating cancellation to the SA. |
This PR was failing tests, due to a change in go-sql-driver/mysql which changed error messages, breaking our string-based Lines 29 to 36 in 581ea05
I have added one commit to this PR which updates map.go and map_test.go to have more resilient versions of both Please review ASAP so we can tag this with the release today, as planned last week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, I'm very happy to see these methods get implemented with errors.As
/.Is
instead of matching on the prefix.
Bumps github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0.
Release notes
Sourced from github.com/go-sql-driver/mysql's releases.
Changelog
Sourced from github.com/go-sql-driver/mysql's changelog.
... (truncated)
Commits
5cee457
update changelog for Version 1.7 (#1376)41dd159
AddAllowFallbackToPlaintext
andTLS
to config (#1370)fa1e4ed
Fix parsing 0 year. (#1257)05bed83
Add CodeQL workflow for GitHub code scanning (#1369)803c0e0
migrate set-output to the environment file (#1368)a477f69
fix: benchmarkExecContext is unused (#1351)0c62bb2
Go1.19 is released (#1350)ad9fa14
Add SQLState to MySQLError (#1321)eff3908
Move default packet size to constant (#1319)90e813f
Add go1.18 to test matrix (#1317)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)