mysqlStmt Implements CheckNamedValue

[zhixinwen]

Description

uint support is broken in v1.5.0 when working with instrument library (which is essentially a wrapper around go-sql-driver/mydriver). The issue is in sql, it would check if the wrapper implements CheckNamedValue. The wrapper does implement CheckNamedValue, but it when it checks the underlying mysqlStmtdoes not implement this, so it just returns driver.ErrSkip (which is the correct behavior to me).

In sql, when it sees driver.ErrSkip, it would use ccChecker.CheckNamedValue to do the conversion. However, it would fail in:

	nv.Value, err = c.cci.ColumnConverter(index).ConvertValue(arg)
	if err != nil {
		return err
	}
	if !driver.IsValue(nv.Value) {
		return fmt.Errorf("driver ColumnConverter error converted %T to unsupported type %T", arg, nv.Value)
	}

because nv.Value would be of type uint64 (before 1.5.0, it would return int64), and driver.IsValue would return false.

The easiest way to fix it is to add CheckNamedValue to mysqlStmt. It also makes the driver complies to the general sql protocol.

Checklist

• Code compiles correctly
• All tests passing
• Added myself / the copyright holder to the AUTHORS file

[julienschmidt]

LGTM. Thanks!

Travis CI is currently failing, but that seems to be due to a broken master in golang/go

[zhixinwen]

Looks like it is still occurring, can we merge this in first?

[julienschmidt]

We will after #1092 is merged (or the golang/go master is fixed).
Sorry for the wait.

[julienschmidt]

#1092 was merged. Kindly rebase your PR on the current master branch (git pull --rebase).
Afterwards it should pass the CI check.

[zhixinwen]

Updated

[julienschmidt]

Thanks!