improve GitHub Actions workflows #1190
Conversation
- add windows to build matrix - use newer versions of MySQL and MariaDB
.github/workflows/test.yml
Outdated
| pull_request: | ||
| push: | ||
| branches: | ||
| - "master" |
There was a problem hiding this comment.
Why restrict the branch?
When I pushed a new branch to my fork and I want to run test, I need to edit this file.
It is cumbersome.
There was a problem hiding this comment.
it comes from starter workflows https://github.com/actions/starter-workflows/blob/c59b62dee0eae1f9f368b7011cf05c2fc42cf084/ci/go.yml#L3-L7
but I agree with you, and will remove it.
|
I'm a little surprised by "shogo82148/actions-setup-mysql@v1" looks great! |
|
Thank you!
me, too. |
* master: (93 commits) return unsigned in database type name when necessary (go-sql-driver#1238) add an invalid DSN test case (go-sql-driver#1235) refactoring (*textRows).readRow in a more clear way (go-sql-driver#1230) use utf8mb4 instead of utf8 in TestCharset (go-sql-driver#1228) improve readability follows go-staticcheck (go-sql-driver#1227) support Is comparison on MySQLError (go-sql-driver#1210) Wording correction in README (go-sql-driver#1218) noCopy implements sync.Locker (go-sql-driver#1216) Fix readme: MaxIdle is same or less than MaxOpen (go-sql-driver#1215) Drop support of Go 1.12 (go-sql-driver#1211) Release v1.6.0 (go-sql-driver#1197) add Go 1.16 to the build matrix (go-sql-driver#1198) Implement driver.Validator interface (go-sql-driver#1174) handling decoding pem error (go-sql-driver#1192) stop rounding times (go-sql-driver#1172) improve GitHub Actions workflows (go-sql-driver#1190) Move tests from Travis to Actions (go-sql-driver#1183) Fix go vet error (go-sql-driver#1173) README: Make usage code more friendly (go-sql-driver#1170) Fix a broken link to cleartext client side plugin (go-sql-driver#1165) ...
Description
Checklist