Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate mysql.NullTime #960

Closed
julienschmidt opened this issue Apr 30, 2019 · 3 comments · Fixed by #1144
Closed

Deprecate mysql.NullTime #960

julienschmidt opened this issue Apr 30, 2019 · 3 comments · Fixed by #1144
Milestone

Comments

@julienschmidt
Copy link
Member

database/sql will have a NullTime type from Go1.13 onward, which should be used instead: golang/go#30305

@dolmen
Copy link
Contributor

dolmen commented Sep 4, 2019

Or better: make mysql.NullTime an alias to database/sql.NullTime when compiling on Go 1.13+.

I will submit a PR to implement this solution.

@dolmen
Copy link
Contributor

dolmen commented Sep 4, 2019

Well, the Scan method is specific to MySQL, so we have to keep it. I will change to wrap database/sql.NullTime.

@AlaNDGT
Copy link

AlaNDGT commented Jun 18, 2020

Will rows.ColumnTypes() (first value from db.Query()) return sql.NullTime instead of mysql.NullTime too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants