Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement database/sql/driver.Validator interface #1106

Closed
julienschmidt opened this issue May 21, 2020 · 7 comments
Closed

Implement database/sql/driver.Validator interface #1106

julienschmidt opened this issue May 21, 2020 · 7 comments
Assignees
Milestone

Comments

@julienschmidt
Copy link
Member

julienschmidt commented May 21, 2020

Issue description

Go 1.15 will introduce a new Validator interface, which may be implemented by Conn to allow drivers to signal if a connection is valid or if it should be discarded:

https://tip.golang.org/pkg/database/sql/driver/#Validator

@julienschmidt julienschmidt added this to the v1.6.0 milestone May 21, 2020
@dilantha111
Copy link

If anyone haven't started on this, I would like to have a look

@julienschmidt
Copy link
Member Author

Go ahead. I assigned you :)

@shogo82148
Copy link
Contributor

@dilantha111 Hi, have you started on this?
Go 1.15 is already released, so I'm looking forward this.

@dilantha111 dilantha111 removed their assignment Oct 19, 2020
@dilantha111
Copy link

Hi @shogo82148 sorry that I was very too late to respond. But now my focus has been shifted, and no longer in go development. I think it's better someone else look into this. Thanks.

@trongbq
Copy link
Contributor

trongbq commented Nov 24, 2020

@julienschmidt If you don't mind, I would like to send a PR for this issue.
My idea is to use mysqlConn#error() method to check if there is any errors atm, then return bool value respectively.

@shogo82148
Copy link
Contributor

@trongbq Sounds good. I assigned you 😄

@shogo82148
Copy link
Contributor

closed by #1174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants