Add SQLState to MySQLError #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shogo82148
requested changes
Apr 6, 2022
There was a problem hiding this comment.
it needs some little memory allocations, but not so frequently.
#1322 is acceptable for me.
@jmhodges @arnehormann @methane How do you think about it?
thopos
force-pushed
the
report-sqlstate-in-MySQLError
branch
from
4ab8a7a
to
14893f1
Compare
methane
reviewed
Apr 7, 2022
methane
reviewed
Apr 8, 2022
thopos
force-pushed
the
report-sqlstate-in-MySQLError
branch
from
14893f1
to
c0031c2
Compare
methane
approved these changes
Apr 12, 2022
methane
reviewed
Apr 12, 2022
methane
requested changes
Apr 12, 2022
to allow library users to distinguish user-defined from client / server errors
thopos
force-pushed
the
report-sqlstate-in-MySQLError
branch
from
c0031c2
to
0e8599a
Compare
methane
reviewed
Apr 13, 2022
methane
approved these changes
Apr 13, 2022
|
Thank you @shogo82148 and @methane for your patience and thorough review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow library users to distinguish user-defined from client / server errors.
Checklist