New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Is comparison on MySQLError #1210
support Is comparison on MySQLError #1210
Conversation
It sounds good. We can drop support Go 1.12 because the latest version of Go is 1.16. |
I think we should drop old versions support now, because we just released v1.6. |
I dropped support of Go 1.12. #1211 |
@methane @shogo82148 looks like the PR checks are failing because of a decrease in coverage because of newly "uncovered" lines in rows.go which this PR doesn't touch. Any suggestions how I can work around that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* master: (93 commits) return unsigned in database type name when necessary (go-sql-driver#1238) add an invalid DSN test case (go-sql-driver#1235) refactoring (*textRows).readRow in a more clear way (go-sql-driver#1230) use utf8mb4 instead of utf8 in TestCharset (go-sql-driver#1228) improve readability follows go-staticcheck (go-sql-driver#1227) support Is comparison on MySQLError (go-sql-driver#1210) Wording correction in README (go-sql-driver#1218) noCopy implements sync.Locker (go-sql-driver#1216) Fix readme: MaxIdle is same or less than MaxOpen (go-sql-driver#1215) Drop support of Go 1.12 (go-sql-driver#1211) Release v1.6.0 (go-sql-driver#1197) add Go 1.16 to the build matrix (go-sql-driver#1198) Implement driver.Validator interface (go-sql-driver#1174) handling decoding pem error (go-sql-driver#1192) stop rounding times (go-sql-driver#1172) improve GitHub Actions workflows (go-sql-driver#1190) Move tests from Travis to Actions (go-sql-driver#1183) Fix go vet error (go-sql-driver#1173) README: Make usage code more friendly (go-sql-driver#1170) Fix a broken link to cleartext client side plugin (go-sql-driver#1165) ...
Description
Adds support for comparison of
MySQLError
instances witherrors.Is
. This useful for comparing errors (either client-side or server-side) in application code, particularly for things like circuit breakers and retriers.Checklist