Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete YARD docs #1762

Closed
connorshea opened this issue Sep 21, 2019 · 12 comments
Closed

Complete YARD docs #1762

connorshea opened this issue Sep 21, 2019 · 12 comments

Comments

@connorshea
Copy link
Member

connorshea commented Sep 21, 2019

Here are all the Faker classes that have been updated with YARD docs/need to be updated:

@Zeragamba
Copy link
Contributor

Oh, I love checklists!

@ashishra0
Copy link
Contributor

Hey @connorshea
Can you please update the checklist? It would be very helpful.
Cheers

@connorshea
Copy link
Member Author

@ashishra0 it should be updated now, I don't check things off until they've been merged into master.

@ashishra0
Copy link
Contributor

@connorshea Yeah makes sense. Thanks though!

@vbrazo
Copy link
Member

vbrazo commented Oct 8, 2019

That's pretty awesome 💥

@Omoyeni663
Copy link

I am still in chapter 3 of my course, I need someone to put me through... Better on Twitter @Melebroz1

@connorshea
Copy link
Member Author

I've updated the issue description with all the new PRs :)

@danielTiringer
Copy link
Contributor

The last one's left is Faker::Code which has an open PR already.
If you want me to complete the Code YARD docs too, please close the existing PR.

@connorshea
Copy link
Member Author

@danielTiringer thank you for all the work! 🙏 Looks like @Zeragamba has created the updated PR for Faker::Code, so that'll be the last one we need to merge and then this'll be finished :)

@Zeragamba
Copy link
Contributor

And that's the last one merged to master!

@connorshea
Copy link
Member Author

Thanks for the great work everybody!

@vbrazo
Copy link
Member

vbrazo commented Jul 17, 2020

That was awesome! Thanks!

@vbrazo vbrazo unpinned this issue Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants