Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add YARD docs to Faker::University #1959

Merged
merged 1 commit into from May 17, 2020
Merged

add YARD docs to Faker::University #1959

merged 1 commit into from May 17, 2020

Conversation

rutger-t
Copy link
Contributor

@rutger-t rutger-t commented Apr 4, 2020 •
edited

Issue#

#1762

Description:

  • Adds YARD docs for Faker::University.
  • Add RuboCop exception for Greek Alphabet.

koic
koic reviewed May 16, 2020
View reviewed changes
lib/faker/default/university.rb
@@ -5,22 +5,67 @@ class University < Base
flexible :university

class << self
##
# Produces a random university name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a period at the end of the sentence?

Suggested change
# Produces a random university name
# Produces a random university name.

The same applies to the other sentences in this PR.

@Zeragamba Zeragamba merged commit 0064d53 into faker-ruby:master May 17, 2020
@Zeragamba Zeragamba mentioned this pull request May 17, 2020
Merged
@connorshea connorshea mentioned this pull request May 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koic koic koic left review comments

Assignees
No one assigned
Labels
📘 Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rutger-t @koic @Zeragamba