Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YARD docs to Faker::South_Africa #2001

Merged
merged 2 commits into from May 21, 2020

Conversation

danielTiringer
Copy link
Contributor

Issue#

#1762

Description:

Add complete YARD docs for Faker::South Africa methods.

Copy link
Member

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few little fixes.

lib/faker/default/south_africa.rb Outdated Show resolved Hide resolved
lib/faker/default/south_africa.rb Outdated Show resolved Hide resolved
lib/faker/default/south_africa.rb Outdated Show resolved Hide resolved
lib/faker/default/south_africa.rb Outdated Show resolved Hide resolved
Copy link
Member

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@connorshea connorshea requested a review from Zeragamba May 21, 2020 05:25
@Zeragamba Zeragamba merged commit 48fcc17 into faker-ruby:master May 21, 2020
@Zeragamba
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants