Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add YARD doc for Faker::Food #1802

Merged
merged 4 commits into from Dec 5, 2019
Merged

Conversation

sap1enza
Copy link
Contributor

@sap1enza sap1enza commented Oct 11, 2019

Issue#

#1762

Description:

Add complete YARD docs for Faker::Food methods.

Copy link
Member

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments :) Thanks!

lib/faker/default/food.rb Outdated Show resolved Hide resolved
lib/faker/default/food.rb Outdated Show resolved Hide resolved
lib/faker/default/food.rb Outdated Show resolved Hide resolved
lib/faker/default/food.rb Outdated Show resolved Hide resolved
lib/faker/default/food.rb Outdated Show resolved Hide resolved
# @example
# Faker::Food.dish #=> "Feijoada"
#
# @faker.version 2.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These versions should be updated to reflect the original versions the methods were added in.

  • fruits and vegetables were added in 1.9.0 with fe586fb
  • description was added in 1.9.0 with 679fd50
  • metric_measurement was added in 1.8.3 with 802423f
  • dish was added in 1.8.0 with 3669579
  • ingredient, spice, and measurement were added in 1.7.0 with f3e08e6

sap1enza and others added 2 commits November 12, 2019 22:18
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
@connorshea connorshea mentioned this pull request Nov 13, 2019
lib/faker/default/food.rb Outdated Show resolved Hide resolved
lib/faker/default/food.rb Outdated Show resolved Hide resolved
lib/faker/default/food.rb Outdated Show resolved Hide resolved
lib/faker/default/food.rb Outdated Show resolved Hide resolved
lib/faker/default/food.rb Outdated Show resolved Hide resolved
lib/faker/default/food.rb Outdated Show resolved Hide resolved
lib/faker/default/food.rb Outdated Show resolved Hide resolved
lib/faker/default/food.rb Outdated Show resolved Hide resolved
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@connorshea @sap1enza good job :) thanks!

Copy link
Member

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbrazo vbrazo merged commit fcc523c into faker-ruby:master Dec 5, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
* add food docs

* Apply suggestions from code review

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>

* Apply suggestions from code review
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* add food docs

* Apply suggestions from code review

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants