Add YARD doc for Faker::Code #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
lib/faker/default/code.rb
Outdated
| # Retrieves a real Amazon ASIN code list taken from | ||
| # https://archive.org/details/asin_listing | ||
| ## | ||
| # Retrieves a real Amazon ASIN code from https://archive.org/details/asin_listing. |
There was a problem hiding this comment.
This URL no longer works. Not sure if it should be kept here?
I tried to find another listing but couldn't find anything
There was a problem hiding this comment.
@lucasqueiroz https://archive.org/details/asin_listing works for me, were you including the period in the URL?
@Zeragamba maybe we should just remove the period at the end of the URL.
There was a problem hiding this comment.
That's probably it then, thanks!
connorshea
reviewed
Jun 24, 2020
connorshea
reviewed
Jun 24, 2020
connorshea
reviewed
Jun 24, 2020
connorshea
requested changes
Jun 24, 2020
Zeragamba
force-pushed
the
faker-code-docs
branch
from
2425ba7
to
5ba345f
Compare
Zeragamba
force-pushed
the
faker-code-docs
branch
from
5ba345f
to
fe963d6
Compare
|
sorry for the delay. Thought I had made those changes... apparently not :P |
lucasqueiroz
approved these changes
Jul 15, 2020
connorshea
requested changes
Jul 16, 2020
There was a problem hiding this comment.
@Zeragamba One last thing and then I swear it's done! You can apply these changes and then merge :)
Co-authored-by: Connor Shea <connor.james.shea@gmail.com>
Co-authored-by: Connor Shea <connor.james.shea@gmail.com>
Co-authored-by: Connor Shea <connor.james.shea@gmail.com>
Co-authored-by: Connor Shea <connor.james.shea@gmail.com>
gabrielbaldao
pushed a commit
to gabrielbaldao/faker
that referenced
this pull request
Jul 22, 2020
* Add YARD doc for Faker::Code * update version tags * use ascii characters * fix documentation * restrict values for base * fix code review comments * Update lib/faker/default/code.rb Co-authored-by: Connor Shea <connor.james.shea@gmail.com> * Update lib/faker/default/code.rb Co-authored-by: Connor Shea <connor.james.shea@gmail.com> * Update lib/faker/default/code.rb Co-authored-by: Connor Shea <connor.james.shea@gmail.com> * Update lib/faker/default/code.rb Co-authored-by: Connor Shea <connor.james.shea@gmail.com> Co-authored-by: Cuthbert Guerrero <cguerrero@zendesk.com> Co-authored-by: Vitor Oliveira <vbrazo@gmail.com> Co-authored-by: Connor Shea <connor.james.shea@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
#1762 (includes #1961)
Description:
The PR adds YARD docs for Faker::Code