Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YARD docs for Faker::Music{,::Opera} #1873

Merged
merged 2 commits into from Dec 23, 2019

Conversation

jas14
Copy link
Contributor

@jas14 jas14 commented Dec 22, 2019

Issue#

#1762

Description:

Adds YARD docs for Faker::Music and Faker::Music::Opera.

#
# @return [Array<String>]
#
# @faker.version 1.6.4
def keys
%w[C D E F G A B]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's not related to your Pull Request, I'm just commenting so we can discuss it :)
Maybe this should become an array inside the localization file or perhaps a constant? (I'd prefer the latter since it probably won't ever change?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, I'll push another commit to this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, seems it's already been merged 🤷‍♂ @lucasqueiroz want me to open another?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you can open a new PR please. Thanks for contributing @jas14

@vbrazo vbrazo merged commit 179ff34 into faker-ruby:master Dec 23, 2019
@connorshea connorshea mentioned this pull request Dec 23, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
* Add Faker::Music YARD docs

* Add Faker::MUsic::Opera YARD docs
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Add Faker::Music YARD docs

* Add Faker::MUsic::Opera YARD docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants