Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YARD docs to Faker::JSON #2000

Merged
merged 2 commits into from May 20, 2020
Merged

Add YARD docs to Faker::JSON #2000

merged 2 commits into from May 20, 2020

Conversation

danielTiringer
Copy link
Contributor

Issue#

#1762

Description:

Add complete YARD docs for Faker::JSON methods.

@danielTiringer danielTiringer deleted the add-json-docs branch May 20, 2020 20:59
@danielTiringer danielTiringer restored the add-json-docs branch May 20, 2020 20:59
Zeragamba
Zeragamba requested changes May 20, 2020
View reviewed changes
lib/faker/default/json.rb Outdated Show resolved Hide resolved
@Zeragamba Zeragamba merged commit a7aa808 into faker-ruby:master May 20, 2020
@Zeragamba
Copy link
Contributor

Thanks again!

@danielTiringer danielTiringer deleted the add-json-docs branch May 20, 2020 22:07
@connorshea connorshea mentioned this pull request May 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeragamba Zeragamba Zeragamba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielTiringer @Zeragamba