Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faker::WorldCup YARD docs #1789

Merged
merged 5 commits into from Oct 10, 2019
Merged

Conversation

ashishra0
Copy link
Contributor

@ashishra0 ashishra0 commented Oct 4, 2019

Add YARD docs for Faker::WorldCup [ #1762 ]

@ashishra0 ashishra0 closed this Oct 4, 2019
@ashishra0 ashishra0 reopened this Oct 4, 2019
Copy link
Member

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback :)

def stadium
fetch('world_cup.stadiums')
end

##
# Produces a random national team name from a group. See below examples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the "See below examples." from these descriptions :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright will do :)

lib/faker/default/world_cup.rb Outdated Show resolved Hide resolved
lib/faker/default/world_cup.rb Outdated Show resolved Hide resolved
lib/faker/default/world_cup.rb Outdated Show resolved Hide resolved
ashishra0 and others added 3 commits October 5, 2019 15:43
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
@connorshea connorshea mentioned this pull request Oct 8, 2019
@vbrazo vbrazo merged commit 6ed77ac into faker-ruby:master Oct 10, 2019
vbrazo added a commit that referenced this pull request Oct 10, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
* add YARD docs

* remove empty line

* Update lib/faker/default/world_cup.rb

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>

* Update lib/faker/default/world_cup.rb

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>

* Update lib/faker/default/world_cup.rb

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* add YARD docs

* remove empty line

* Update lib/faker/default/world_cup.rb

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>

* Update lib/faker/default/world_cup.rb

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>

* Update lib/faker/default/world_cup.rb

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants