Update rubocop requirement from ~> 0.88.0 to ~> 0.90.0 in /common #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v0.88.0...v0.90.0) Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
ruby
|
This becomes important because of rubocop/rubocop-ast#113 rubocop-ast-0.4.0 breaks our CI. I think we'd rather roll rubocop forward than rubocop-ast back. |
|
@feelepxyz @jurre AFAICT the biggest blocker here is Do we have any sense what our new target should be? The new default, I'm tempted to:
Since the scope of (2) varies wildly based on the value picked in (1): does |
Seems ok, this has happened a few times already so cool with relaxing this a bit. |
reconsider `MissingSuper`, as there are plenty of hits in the first extension module we encountered.
feelepxyz
reviewed
Sep 15, 2020
feelepxyz
reviewed
Sep 15, 2020
Co-authored-by: Philip Harrison <philip@mailharrison.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Human extension of Dependabot's start
Lint/MissingSuper,Style/KeywordParametersOrder,Style/OptionalBooleanParameter,Style/StringConcatenationdisabledMetrics/PerceivedComplexity, which changed calculation methods10, from7previously, or8as the default in0.90.0Style/SoleNestedConditionalcorrections: look forif/unlessin diffsUpdates the requirements on rubocop to permit the latest version.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
Commits
95305ffCut 0.90eb04490Merge pull request #8595 from marcandre/struct_autocorrect71c4818Merge branch 'master' into struct_autocorrect6d781b0Revert "Mark Cops and Formatters as private"f69a7a8Merge pull request #8624 from Skipants/masterf877e02FixStyle/CaseLikeIfnot properly handling overriden equality methods6cab599Add workaround to avoid crash in Truffleruby (#8602)2b7607cFix an infinite loop error forLayout/EmptyLineBetweenDefs31a921dUseCop::BaseAPI forLayoutdepartment [T-Z]6c05f69UseCop::BaseAPI forLayoutdepartment [N-S]Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)