Handle to_h with block in Style/HashTransformKeys and Style/HashTransformValues #8517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
eugeneius
force-pushed
the
hash_transformation_to_h_with_block
branch
from
c526b5e
to
2be0656
Compare
koic
reviewed
Aug 11, 2020
| @@ -81,6 +81,17 @@ | |||
| RUBY | |||
| end | |||
|
|
|||
| it 'flags _.to_h {...} when transform_values could be used' do | |||
There was a problem hiding this comment.
I think it should necessary to detect it only for Ruby 2.6 or higher. It should not detected in Ruby 2.5 or lower.
% ruby -v
ruby 2.5.8p224 (2020-03-31 revision 67882) [x86_64-darwin17]
% ruby -e "p({a: 1, b: 2, c: 3}.to_h { |k, v| [k, -v] })"
{:a=>1, :b=>2, :c=>3}
% ruby -e "p({a: 1, b: 2, c: 3}.transform_values { |v| -v })"
{:a=>-1, :b=>-2, :c=>-3}There was a problem hiding this comment.
Fixed, thanks @koic! 🙇
Since Ruby 2.6, `Hash#to_h` accepts a block which is called with each
pair and must return a key and value to include in the new hash.
If either the key or the value are always returned unchanged, using
`Hash#transform_keys` or `Hash#transform_values` is faster and clearer.
This is similar to the existing logic that detects `map { ... }.to_h`.
eugeneius
force-pushed
the
hash_transformation_to_h_with_block
branch
from
2be0656
to
6f754c5
Compare
|
Good catch! Thanks @eugeneius! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #7663.
Since Ruby 2.6,
Hash#to_haccepts a block which is called with each pair and must return a key and value to include in the new hash: https://rubyreferences.github.io/rubychanges/2.6.html#to_h-with-a-blockIf either the key or the value are always returned unchanged, using
Hash#transform_keysorHash#transform_valuesis faster and clearer.This is similar to the existing logic that detects
map { ... }.to_h.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.